Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum amount of planes, cities, etc #10

Open
WizzardMaker opened this issue Oct 2, 2019 · 6 comments
Open

Maximum amount of planes, cities, etc #10

WizzardMaker opened this issue Oct 2, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@WizzardMaker
Copy link
Member

A lot of people requested on multiple occasions, whether it was possible to change the limit on the amount of entries in the given .csv files.
Well now we can 😃
It should only need some changing of the MAX_* values in the Defines.h and everything is hunky dory.

@CrossVR
Copy link
Collaborator

CrossVR commented Oct 3, 2019 via email

@WizzardMaker
Copy link
Member Author

WizzardMaker commented Oct 3, 2019

I would look at what int is being used and then just slap a the corresponding max value onto it 🙂

@CrossVR
Copy link
Collaborator

CrossVR commented Oct 3, 2019 via email

@WizzardMaker
Copy link
Member Author

WizzardMaker commented Oct 3, 2019

Yeah, they resize the arrays according to the MAX_ limits. But those resizes often happen right before reading the files, so maybe we can just use the file length (in lines) to set the maximum, as it won't fill the array anywhere else

@CrossVR
Copy link
Collaborator

CrossVR commented Oct 3, 2019

That's true for MAX_PLANES, but not for MAX_CITIES which is used in loop conditions and array declarations across the codebase

@WizzardMaker
Copy link
Member Author

I think MAX_CITIES is an exception for removing the limit, it works fine if we raise the limit just a bit. Nobody would want to add more than 200 cities

@CrossVR CrossVR added the enhancement New feature or request label Oct 5, 2019
WizzardMaker added a commit that referenced this issue Sep 25, 2022
Fix endless loop in Editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants