This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Adds the ability to flip horizontally #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
|
|
||
| public FlipViewController(Context context, boolean orientationVertical) { |
There was a problem hiding this comment.
How about changing it to FlipViewController(Context context, int orientation)? The valid values of orientation could be the constants you've already declared.
openaphid
added a commit
that referenced
this pull request
Nov 9, 2012
Adds the ability to flip horizontally
openaphid
pushed a commit
that referenced
this pull request
Nov 9, 2012
Conflicts: FlipView/Demo/AndroidManifest.xml FlipView/Demo/src/com/aphidmobile/flip/demo/MainActivity.java FlipView/FlipLibrary/src/com/aphidmobile/flip/FlipCards.java FlipView/FlipLibrary/src/com/aphidmobile/flip/FlipViewController.java
|
I also found a minor issue about the incorrect rendering of shadow in horizontal mode. Thanks for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple optional parameter to FlipViewController to toggle horizontal or vertical flipping.
Old constructor:
public FlipViewController(Context context) {
New constructor:
public FlipViewController(Context context, boolean orientationVertical);