Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test]Dev labservices microsoft.lab services 2021 10 01 preview #2985

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

msyyc
Copy link

@msyyc msyyc commented Sep 14, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Sep 14, 2021

Swagger Validation Report

️🔄BreakingChange inProgress [Detail]
️🔄LintDiff inProgress [Detail]
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Sep 14, 2021

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌[Staging] SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

azure-sdk-for-python-track2 - track2_azure-mgmt-labservices - 1.0.0
+	Model Lab no longer has parameter created_by_object_id
+	Model Lab no longer has parameter created_by_user_principal_name
+	Model Lab no longer has parameter created_date
+	Model Lab no longer has parameter invitation_code
+	Model Lab no longer has parameter latest_operation_result
+	Model Lab no longer has parameter max_users_in_lab
+	Model Lab no longer has parameter unique_identifier
+	Model Lab no longer has parameter usage_quota
+	Model Lab no longer has parameter user_access_mode
+	Model Lab no longer has parameter user_quota
+	Model Resource no longer has parameter location
+	Model Resource no longer has parameter tags
+	Model User no longer has parameter family_name
+	Model User no longer has parameter given_name
+	Model User no longer has parameter latest_operation_result
+	Model User no longer has parameter location
+	Model User no longer has parameter tags
+	Model User no longer has parameter tenant_id
+	Model User no longer has parameter unique_identifier
+	Operation LabsOperations.begin_delete has a new signature
+	Operation LabsOperations.get has a new signature
+	Operation LabsOperations.get has a new signature
+	Operation UsersOperations.begin_delete has a new signature
+	Operation UsersOperations.get has a new signature
+	Operation UsersOperations.get has a new signature
+	Parameter email of model User is now required
+	Parameter email of model User is now required
+	Parameter location of model Lab is now required
+	Parameter status of model OperationResult is now required
+	Removed operation LabsOperations.add_users
+	Removed operation LabsOperations.create_or_update
+	Removed operation LabsOperations.list
+	Removed operation LabsOperations.register
+	Removed operation LabsOperations.update
+	Removed operation Operations.get
+	Removed operation UsersOperations.create_or_update
+	Removed operation UsersOperations.list
+	Removed operation UsersOperations.update
+	Removed operation group EnvironmentSettingsOperations
+	Removed operation group EnvironmentsOperations
+	Removed operation group GalleryImagesOperations
+	Removed operation group GlobalUsersOperations
+	Removed operation group LabAccountsOperations
+	Removed operation group ProviderOperationsOperations
️✔️azure-sdk-for-go - labservices/mgmt/2018-10-15/labservices - v57.2.0
️❌ azure-sdk-for-net failed [Detail]
  • Failed [Logs] Generate from 6fd570efc5a827441bbefb08048317560a92ba53. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	sudo apt-get install -y dotnet-sdk-5.0
    command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.84 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/labservices/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • Microsoft.Azure.Management.LabServices [View full logs]  [Preview SDK Changes]
    cmdout	[msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/labservices/Microsoft.Azure.Management.LabServices/tests/Tests/LabServicesTestBase.cs(50,16): error CS0246: The type or namespace name 'ManagedLabsClient' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/labservices/Microsoft.Azure.Management.LabServices/tests/Microsoft.Azure.Management.LabServices.Tests.csproj]
    cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/labservices/Microsoft.Azure.Management.LabServices/tests/Tests/LabServicesTestBase.cs(50,16): error CS0246: The type or namespace name 'ManagedLabsClient' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/labservices/Microsoft.Azure.Management.LabServices/tests/Microsoft.Azure.Management.LabServices.Tests.csproj]
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from 6fd570efc5a827441bbefb08048317560a92ba53. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️track2_azure-mgmt-labservices [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Model User has a new parameter invitation_state
    info	[Changelog]   - Model User has a new parameter system_data
    info	[Changelog]   - Model User has a new parameter invitation_sent
    info	[Changelog]   - Model User has a new parameter additional_usage_quota
    info	[Changelog]   - Model User has a new parameter display_name
    info	[Changelog]   - Model User has a new parameter registration_state
    info	[Changelog]   - Model Lab has a new parameter description
    info	[Changelog]   - Model Lab has a new parameter security_profile
    info	[Changelog]   - Model Lab has a new parameter system_data
    info	[Changelog]   - Model Lab has a new parameter title
    info	[Changelog]   - Model Lab has a new parameter auto_shutdown_profile
    info	[Changelog]   - Model Lab has a new parameter connection_profile
    info	[Changelog]   - Model Lab has a new parameter network_profile
    info	[Changelog]   - Model Lab has a new parameter state
    info	[Changelog]   - Model Lab has a new parameter virtual_machine_profile
    info	[Changelog]   - Model Lab has a new parameter lab_plan_id
    info	[Changelog]   - Model Lab has a new parameter roster_profile
    info	[Changelog]   - Model OperationResult has a new parameter start_time
    info	[Changelog]   - Model OperationResult has a new parameter id
    info	[Changelog]   - Model OperationResult has a new parameter end_time
    info	[Changelog]   - Model OperationResult has a new parameter name
    info	[Changelog]   - Model OperationResult has a new parameter percent_complete
    info	[Changelog]   - Added operation LabsOperations.begin_publish
    info	[Changelog]   - Added operation LabsOperations.list_by_resource_group
    info	[Changelog]   - Added operation LabsOperations.begin_sync_group
    info	[Changelog]   - Added operation LabsOperations.begin_update
    info	[Changelog]   - Added operation LabsOperations.begin_create_or_update
    info	[Changelog]   - Added operation LabsOperations.list_by_subscription
    info	[Changelog]   - Added operation Operations.list
    info	[Changelog]   - Added operation UsersOperations.begin_invite
    info	[Changelog]   - Added operation UsersOperations.begin_create_or_update
    info	[Changelog]   - Added operation UsersOperations.begin_update
    info	[Changelog]   - Added operation UsersOperations.list_by_lab
    info	[Changelog]   - Added operation group OperationResultsOperations
    info	[Changelog]   - Added operation group SchedulesOperations
    info	[Changelog]   - Added operation group LabPlansOperations
    info	[Changelog]   - Added operation group VirtualMachinesOperations
    info	[Changelog]   - Added operation group ImagesOperations
    info	[Changelog]
    info	[Changelog] **Breaking changes**
    info	[Changelog]
    info	[Changelog]   - Parameter email of model User is now required
    info	[Changelog]   - Parameter email of model User is now required
    info	[Changelog]   - Parameter location of model Lab is now required
    info	[Changelog]   - Parameter status of model OperationResult is now required
    info	[Changelog]   - Operation UsersOperations.get has a new signature
    info	[Changelog]   - Operation UsersOperations.get has a new signature
    info	[Changelog]   - Operation UsersOperations.begin_delete has a new signature
    info	[Changelog]   - Operation LabsOperations.get has a new signature
    info	[Changelog]   - Operation LabsOperations.get has a new signature
    info	[Changelog]   - Operation LabsOperations.begin_delete has a new signature
    info	[Changelog]   - Model User no longer has parameter tenant_id
    info	[Changelog]   - Model User no longer has parameter tags
    info	[Changelog]   - Model User no longer has parameter given_name
    info	[Changelog]   - Model User no longer has parameter location
    info	[Changelog]   - Model User no longer has parameter latest_operation_result
    info	[Changelog]   - Model User no longer has parameter family_name
    info	[Changelog]   - Model User no longer has parameter unique_identifier
    info	[Changelog]   - Model Lab no longer has parameter usage_quota
    info	[Changelog]   - Model Lab no longer has parameter user_access_mode
    info	[Changelog]   - Model Lab no longer has parameter max_users_in_lab
    info	[Changelog]   - Model Lab no longer has parameter invitation_code
    info	[Changelog]   - Model Lab no longer has parameter created_by_object_id
    info	[Changelog]   - Model Lab no longer has parameter created_by_user_principal_name
    info	[Changelog]   - Model Lab no longer has parameter created_date
    info	[Changelog]   - Model Lab no longer has parameter latest_operation_result
    info	[Changelog]   - Model Lab no longer has parameter user_quota
    info	[Changelog]   - Model Lab no longer has parameter unique_identifier
    info	[Changelog]   - Model Resource no longer has parameter tags
    info	[Changelog]   - Model Resource no longer has parameter location
    info	[Changelog]   - Removed operation LabsOperations.update
    info	[Changelog]   - Removed operation LabsOperations.list
    info	[Changelog]   - Removed operation LabsOperations.register
    info	[Changelog]   - Removed operation LabsOperations.create_or_update
    info	[Changelog]   - Removed operation LabsOperations.add_users
    info	[Changelog]   - Removed operation Operations.get
    info	[Changelog]   - Removed operation UsersOperations.list
    info	[Changelog]   - Removed operation UsersOperations.create_or_update
    info	[Changelog]   - Removed operation UsersOperations.update
    info	[Changelog]   - Removed operation group EnvironmentSettingsOperations
    info	[Changelog]   - Removed operation group ProviderOperationsOperations
    info	[Changelog]   - Removed operation group GalleryImagesOperations
    info	[Changelog]   - Removed operation group EnvironmentsOperations
    info	[Changelog]   - Removed operation group LabAccountsOperations
    info	[Changelog]   - Removed operation group GlobalUsersOperations
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 6fd570efc5a827441bbefb08048317560a92ba53. SDK Automation 14.0.0
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️labservices/mgmt/2018-10-15/labservices [View full logs]  [Preview SDK Changes]
    info	[Changelog] No exported changes
Posted by Swagger Pipeline | How to fix these errors?

@azure-sdk azure-sdk force-pushed the main branch 10 times, most recently from 1607e3f to 18a0704 Compare March 3, 2022 03:02
@azure-sdk azure-sdk force-pushed the main branch 6 times, most recently from f705c8f to f16d6f0 Compare March 10, 2022 15:03
@azure-sdk azure-sdk force-pushed the main branch 9 times, most recently from e61d481 to cbc85d7 Compare July 21, 2022 15:04
@azure-sdk azure-sdk force-pushed the main branch 2 times, most recently from 8bae5b5 to 3ec6574 Compare August 9, 2022 15:05
@MaryGao MaryGao force-pushed the main branch 2 times, most recently from c9d3abd to ff6b6bf Compare March 24, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants