Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test purview #3545

Merged
merged 2 commits into from
Jul 25, 2022
Merged

test purview #3545

merged 2 commits into from
Jul 25, 2022

Conversation

dw511214992
Copy link

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Jul 22, 2022

Swagger Validation Report

️❌BreakingChange: 26 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.9.6)] new version base version
2019-11-01-preview 2019-11-01-preview(38b3d47) 2019-11-01-preview(main)
2021-07-01-preview 2021-07-01-preview(38b3d47) 2021-07-01-preview(main)
Rule Message
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/' removed or restructured?
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L28:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/listkeys' removed or restructured?
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L100:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/regeneratekeys' removed or restructured?
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L133:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/collections/{collectionName}' removed or restructured?
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L174:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/collections' removed or restructured?
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L292:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/collections/{collectionName}/getChildCollectionNames' removed or restructured?
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L334:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/collections/{collectionName}/getCollectionPath' removed or restructured?
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L382:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/resourceSetRuleConfigs/defaultResourceSetRuleConfig' removed or restructured?
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L421:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/resourceSetRuleConfigs' removed or restructured?
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L524:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/metadataRoles' removed or restructured?
Old: Azure.Analytics.Purview.MetadataPolicies/preview/2021-07-01-preview/purviewMetadataPolicy.json#L8:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/metadataPolicies' removed or restructured?
Old: Azure.Analytics.Purview.MetadataPolicies/preview/2021-07-01-preview/purviewMetadataPolicy.json#L54:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/metadataPolicies/{policyId}' removed or restructured?
Old: Azure.Analytics.Purview.MetadataPolicies/preview/2021-07-01-preview/purviewMetadataPolicy.json#L106:5
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'DataPlaneAccountUpdateParameters' removed or renamed?
New: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L19:3
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L567:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AccessKeyOptions' removed or renamed?
New: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L19:3
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L567:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Collection' removed or renamed?
New: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L19:3
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L567:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CollectionReference' removed or renamed?
New: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L19:3
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L567:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ResourceSetRuleConfig' removed or renamed?
New: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L19:3
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L567:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PathPatternExtractorConfig' removed or renamed?
New: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L19:3
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L567:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AdvancedResourceSet' removed or renamed?
New: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L19:3
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L567:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CollectionReference' removed or renamed?
New: Azure.Analytics.Purview.MetadataPolicies/preview/2021-07-01-preview/purviewMetadataPolicy.json#L8:3
Old: Azure.Analytics.Purview.MetadataPolicies/preview/2021-07-01-preview/purviewMetadataPolicy.json#L214:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'MetadataPolicyProperties' removed or renamed?
New: Azure.Analytics.Purview.MetadataPolicies/preview/2021-07-01-preview/purviewMetadataPolicy.json#L8:3
Old: Azure.Analytics.Purview.MetadataPolicies/preview/2021-07-01-preview/purviewMetadataPolicy.json#L214:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'MetadataPolicy' removed or renamed?
New: Azure.Analytics.Purview.MetadataPolicies/preview/2021-07-01-preview/purviewMetadataPolicy.json#L8:3
Old: Azure.Analytics.Purview.MetadataPolicies/preview/2021-07-01-preview/purviewMetadataPolicy.json#L214:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'api-version' removed or renamed?
New: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L20:3
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L1592:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'endpoint' removed or renamed?
New: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L20:3
Old: Azure.Analytics.Purview.Account/preview/2019-11-01-preview/account.json#L1592:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'api-version' removed or renamed?
New: Azure.Analytics.Purview.MetadataPolicies/preview/2021-07-01-preview/purviewMetadataPolicy.json#L9:3
Old: Azure.Analytics.Purview.MetadataPolicies/preview/2021-07-01-preview/purviewMetadataPolicy.json#L525:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'Endpoint' removed or renamed?
New: Azure.Analytics.Purview.MetadataPolicies/preview/2021-07-01-preview/purviewMetadataPolicy.json#L9:3
Old: Azure.Analytics.Purview.MetadataPolicies/preview/2021-07-01-preview/purviewMetadataPolicy.json#L525:3
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️❌LintDiff: 5 Errors, 0 Warnings failed [Detail] The following errors/warnings are introduced by current PR:
Rule Message
AutoRest exception "location":"specification/purview/data-plane/administration/readme.md",
"tag":"package-composite-1",
"details":"swagger-document/compose - FAILED"
AutoRest exception "location":"specification/purview/data-plane/administration/readme.md",
"tag":"package-composite-1",
"details":"Error: The 'title' across provided OpenAPI definitions has to match. Found: 'DataPlaneAccountClient',
'Purview Metadata Policies Service REST API Document'. Please adjust or provide an override (--title=...)."
AutoRest exception "location":"specification/purview/data-plane/readme.md",
"tag":"package-2021-07-01-preview",
"details":"swagger-document-override/md-override-loader - FAILED"
AutoRest exception "location":"specification/purview/data-plane/readme.md",
"tag":"package-2021-07-01-preview",
"details":"Error: Could not read 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/purview/data-plane/Azure.Analytics.Purview.MetadataPolicies/preview/2021-07-01-preview/purviewMetadataPolicy.json'."
AutoRest exception "location":"specification/purview/data-plane/readme.md",
"tag":"package-2021-07-01-preview",
"details":"swagger-document/loader - FAILED"
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
Rule Message
NO_JSON_FILE_FOUND The JSON file is not found but it is referenced from the readme file.
readme: specification/purview/data-plane/readme.md
json: Azure.Analytics.Purview.MetadataPolicies/preview/2021-07-01-preview/purviewMetadataPolicy.json
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation

  • The following tags are being changed in this PR
    • "https://github.com/openapi-env-test/azure-rest-api-specs/blob/38b3d47203d197c01c3e03961617ad2a302595aa/specification/purview/data-plane/administration/readme.md#tag-package-composite-1">purview/data-plane/administration/readme.md#package-composite-1
    • "https://github.com/openapi-env-test/azure-rest-api-specs/blob/38b3d47203d197c01c3e03961617ad2a302595aa/specification/purview/data-plane/readme.md#tag-package-2021-07-01-preview">purview/data-plane/readme.md#package-2021-07-01-preview
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Jul 22, 2022

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed [Logs]Release - Generate from 9ad82ba. SDK Automation 14.0.0
    Only show 30 items here, please refer to log for details.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 605 | �[0m … rtifacts += �[96mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mCannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because it does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:521
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 521 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to generate sdk artifact
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:521
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 521 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to generate sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:605
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 605 | �[0m … rtifacts += �[96mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mCannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because it does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:521
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 521 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to generate sdk artifact
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
  • Azure.Analytics.Purview.Account [View full logs]  [Release SDK Changes]
    info	[Changelog]
  • Azure.Analytics.Purview.Administration [View full logs]  [Release SDK Changes]
    info	[Changelog]
  • Azure.Analytics.Purview.Catalog [View full logs]  [Release SDK Changes]
    info	[Changelog]
  • Azure.Analytics.Purview.Scanning [View full logs]  [Release SDK Changes]
    info	[Changelog]
️❌ azure-sdk-for-js failed [Detail]
  • Failed [Logs]Release - Generate from 9ad82ba. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    warn		specification/purview/data-plane/readme.md skipped due to azure-sdk-for-js not found in swagger-to-sdk
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    cmderr	[automation_generate.sh] [ERROR] get 0 readme files
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-js]: sh .scripts/automation_generate.sh
    warn	Skip package processing as generation is failed
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    warn	No file changes detected after generation
    warn	No package detected after generation
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 9ad82ba. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    warn		specification/purview/data-plane/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]  global `--global`, `--local` are deprecated. Use `--location=global` instead.
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.11.0 -> 8.15.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.15.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.15.0` to update!
    cmderr	[automation_generate.sh] npm notice
    warn	No file changes detected after generation
    warn	No package detected after generation
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 9ad82ba. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    warn		specification/purview/data-plane/readme.md skipped due to azure-sdk-for-java not found in swagger-to-sdk
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    warn	No file changes detected after generation
    warn	No package detected after generation
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app-test
Copy link

openapi-pipeline-app-test bot commented Jul 22, 2022

Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@chunyu3
Copy link

chunyu3 commented Jul 25, 2022

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants