Skip to content

List params default broken #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbanty opened this issue Aug 24, 2020 · 0 comments
Closed

List params default broken #170

dbanty opened this issue Aug 24, 2020 · 0 comments
Labels
🐞bug Something isn't working
Milestone

Comments

@dbanty
Copy link
Collaborator

dbanty commented Aug 24, 2020

I don't think it ever worked, but the default value for list parameters (query params) is set to a field with a default factory.

Instead, we probably need to have some sort of a sentinel value and, if set to that, assign the default. Or, ignore defaults for lists altogether for now, removing a feature that doesn't work is better than generating broken code I think.

@dbanty dbanty added the 🐞bug Something isn't working label Aug 24, 2020
@dbanty dbanty added this to the 0.6.0 milestone Aug 24, 2020
@dbanty dbanty closed this as completed Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant