Skip to content

Allow lower version of python-dateutil in generated client #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bowenwr opened this issue Jan 13, 2021 · 1 comment
Closed

Allow lower version of python-dateutil in generated client #298

bowenwr opened this issue Jan 13, 2021 · 1 comment
Labels
✨ enhancement New feature or improvement

Comments

@bowenwr
Copy link
Contributor

bowenwr commented Jan 13, 2021

Is your feature request related to a problem? Please describe.

Pretty selfish ask here, but we'd like to consider allowing a wider range of allowed python-dateutil, specifically allowing something below 2.8.1 in the generated client TOML.

Some of our internal tooling which uses both our generated openapi client and aws-sam-cli is incompatible due to a dependency conflict. Specifically, aws-sam-cli requires python-dateutil < 2.8.1. We asked about expanding the acceptable range in aws-sam-cli, since the .1 patch version in particular seems arbitrary and were basically told to pound sand.

I know this is pretty esoteric to our individual use case, but thought I'd ask.

Describe the solution you'd like

Support a more permissive range of python-dateutil under 2.8.1.

Describe alternatives you've considered

We can either make this change in our fork directly - which I was hoping to avoid because I'd like to be able to soon ignore our fork and just use the dependency as is - or continue an internal workaround we have around not using the tooling that causes the dependency conflict.

@bowenwr bowenwr added the ✨ enhancement New feature or improvement label Jan 13, 2021
@dbanty
Copy link
Collaborator

dbanty commented Jan 13, 2021

I have no problems with that, the only reason for the current version specifier is because that's the version that came up when I added it and the only one I tested with 😁.

Also I read the sam-cli GitHub issue and... that's rough.

bowenwr added a commit to benchling/openapi-python-client that referenced this issue Jan 14, 2021
dbanty added a commit that referenced this issue Jan 14, 2021
#298 (#299)

* Lower version requirements for python-dateutil in generated client #298

* Update CHANGELOG.md

Co-authored-by: Dylan Anthony <43723790+dbanty@users.noreply.github.com>

Co-authored-by: Dylan Anthony <43723790+dbanty@users.noreply.github.com>
@bowenwr bowenwr closed this as completed Jan 20, 2021
bowenwr added a commit to benchling/openapi-python-client that referenced this issue Jan 20, 2021
openapi-generators#298 (openapi-generators#299)

* Lower version requirements for python-dateutil in generated client openapi-generators#298

* Update CHANGELOG.md

Co-authored-by: Dylan Anthony <43723790+dbanty@users.noreply.github.com>

Co-authored-by: Dylan Anthony <43723790+dbanty@users.noreply.github.com>
bowenwr added a commit to benchling/openapi-python-client that referenced this issue Jan 28, 2021
openapi-generators#298 (openapi-generators#299)

* Lower version requirements for python-dateutil in generated client openapi-generators#298

* Update CHANGELOG.md

Co-authored-by: Dylan Anthony <43723790+dbanty@users.noreply.github.com>

Co-authored-by: Dylan Anthony <43723790+dbanty@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants