don't declare unused variable if model has no properties #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eli-bl
force-pushed
the
issue-1108-empty-object
branch
from
a43da72 to
3bd2160
Compare
dbanty
changed the title
dbanty
approved these changes
Sep 2, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 7, 2024
> [!IMPORTANT] > Merging this pull request will create this release ## Features ### Improved property-merging behavior with `allOf` When using `allOf` to extend a base object type, `openapi-python-client` is now able to handle some kinds of modifications to an existing property that would have previously caused an error: - Overriding attributes that do not affect validation, such as `description`. - Combining properties that this generator ignores, like `maxLength` or `pattern`. - Combining a generic numeric type with `int` (resulting in `int`). - Adding a `format` to a string. - Combining `any` with a specific type (resulting in that specific type). - Adding or overriding a `default` > [!NOTE] > `pattern` and `max_length` are no longer fields on `StringProperty`, which may impact custom templates. This also fixes a bug where properties of inline objects (as opposed to references) were not using the merge logic, but were simply overwriting previous definitions of the same property. ## Fixes - Allow default values for properties of `Any` type ### Produce valid code for an object that has no properties at all Fixed by PR #1109. Thanks @eli-bl! Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1108.