Skip to content

Better error handling when fetching documents #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Conversation

dbanty
Copy link
Collaborator

@dbanty dbanty commented Aug 5, 2020

closes #128

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #132 into main will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #132      +/-   ##
===========================================
+ Coverage   99.91%   100.00%   +0.08%     
===========================================
  Files          40        40              
  Lines        1124      1158      +34     
===========================================
+ Hits         1123      1158      +35     
+ Misses          1         0       -1     
Impacted Files Coverage Δ
openapi_python_client/__init__.py 100.00% <100.00%> (+0.67%) ⬆️
openapi_python_client/parser/errors.py 100.00% <0.00%> (ø)
openapi_python_client/parser/openapi.py 100.00% <0.00%> (ø)
openapi_python_client/parser/reference.py 100.00% <0.00%> (ø)
openapi_python_client/parser/responses.py 100.00% <0.00%> (ø)
openapi_python_client/parser/properties.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cca302...260cf43. Read the comment docs.

@dbanty dbanty merged commit 3ecda49 into main Aug 5, 2020
@dbanty dbanty deleted the better_fetching_errors branch August 5, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nicer error on invalid URL
1 participant