Skip to content

Conversation

@dbanty
Copy link
Collaborator

@dbanty dbanty commented Oct 27, 2025

No description provided.

@dbanty dbanty requested a review from Copilot October 27, 2025 23:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request upgrades the codebase to Python 3.10+ syntax by replacing the legacy typing.Union and typing.Optional syntax with modern pipe union operators (|), removing the typing-extensions dependency, and updating the minimum Python version requirement from 3.9 to 3.10. It also adds from __future__ import annotations to generated model files to enable forward reference compatibility.

Key changes:

  • Replaced Union[X, Y] with X | Y and Optional[X] with X | None throughout the codebase
  • Updated minimum Python version to 3.10 across all configuration files
  • Removed typing-extensions dependency
  • Added from __future__ import annotations import to generated models
  • Updated union type sorting to use pipe operators with case-insensitive alphabetical ordering

Reviewed Changes

Copilot reviewed 235 out of 239 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pyproject.toml Updated minimum Python version to 3.10 and removed typing-extensions dependency
openapi_python_client/templates/*.jinja Updated templates to use pipe union syntax and added from __future__ import annotations
openapi_python_client/parser/**/*.py Converted Union/Optional syntax to pipe operators throughout parser code
openapi_python_client/schema/**/*.py Updated OpenAPI schema models to use modern type annotation syntax
tests/**/*.py Updated test files to use pipe operators and removed Union/Optional imports
integration-tests/**/*.py Updated integration test files and generated clients to match new syntax
end_to_end_tests/**/*.py Updated end-to-end test files and golden records with new type annotation syntax

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dbanty dbanty force-pushed the push-vpmknszlpoon branch from 520a53e to dc1bd2a Compare October 27, 2025 23:49
@dbanty dbanty force-pushed the push-vpmknszlpoon branch from dc1bd2a to 9e30953 Compare October 27, 2025 23:52
@dbanty dbanty merged commit ff34530 into main Oct 28, 2025
22 checks passed
@dbanty dbanty deleted the push-vpmknszlpoon branch October 28, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants