Added support for octet-stream content type (#116) #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 41 41
Lines 1253 1262 +9
=========================================
+ Hits 1253 1262 +9
Continue to review full report at Codecov.
|
dbanty
requested changes
Aug 13, 2020
| @@ -101,6 +118,8 @@ def response_from_data(*, status_code: int, data: Union[oai.Response, oai.Refere | |||
| return Response(status_code=status_code) | |||
| if response_type == "array" and isinstance(schema_data.items, oai.Reference): | |||
| return ListRefResponse(status_code=status_code, reference=Reference.from_ref(schema_data.items.ref),) | |||
| if response_type == "string" and schema_data.schema_format in {"binary", "base64"}: | |||
There was a problem hiding this comment.
I think you want "byte" instead of "base64" per OpenAPI spec. I don't think base64 is a standard format.
Suggested change
| if response_type == "string" and schema_data.schema_format in {"binary", "base64"}: | |
| if response_type == "string" and schema_data.schema_format in {"binary", "byte"}: |
There was a problem hiding this comment.
I think its byte for data and base64 for responses
dbanty
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116