Skip to content

Remove trailing comma in endpoint_macros.pyi #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2020
Merged

Remove trailing comma in endpoint_macros.pyi #178

merged 2 commits into from
Sep 4, 2020

Conversation

dtkav
Copy link
Contributor

@dtkav dtkav commented Sep 3, 2020 •
edited
Loading

Description

Fixes #179

image

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #178 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #178   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        41           
  Lines         1276      1276           
=========================================
  Hits          1276      1276

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 849be6e...a2337e8. Read the comment docs.

@dtkav dtkav mentioned this pull request Sep 3, 2020
Closed
@dtkav
Copy link
Contributor Author

dtkav commented Sep 3, 2020

Let me know if you'd like me to rebase onto a different branch.
Fantastic work on the project!

dbanty
dbanty approved these changes Sep 4, 2020
View reviewed changes
Copy link
Collaborator

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! I was kinda hoping the latest version of black would just solve a lot of my problems. The comma handling is better but definitely still not perfect 😁.

@dbanty dbanty merged commit 7f4d83a into openapi-generators:main Sep 4, 2020
dbanty pushed a commit that referenced this pull request Sep 4, 2020
@dtkav @dbanty
Remove trailing comma in endpoint_macros.pyi (#178)
30edc56 
* Fixes #179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanty dbanty dbanty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated client fails flake8 due to trailing comma
2 participants
@dtkav @dbanty