Fix additionalProperty Union spacing and construction (#266) #273
Conversation
check for list not List in isinstance cast primitives returned by union property's _parse_*
- Added CHANGELOG entry - Change inner_properties_without_template to bool generated once - Change inner_properties_with_template to generator
Codecov Report
@@ Coverage Diff @@
## main #273 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 46 46
Lines 1314 1324 +10
=========================================
+ Hits 1314 1324 +10
Continue to review full report at Codecov.
|
| def __attrs_post_init__(self) -> None: | ||
| super().__attrs_post_init__() | ||
| object.__setattr__( | ||
| self, "has_properties_without_templates", any(prop.template is None for prop in self.inner_properties) | ||
| ) |
There was a problem hiding this comment.
Any reason for doing it this way vs. doing
@property
def has_properties_without_templates(self) -> bool:
return any(prop.template is None for prop in self.inner_properties)?
I guess this way may be a bit more efficient as its only being computed once
There was a problem hiding this comment.
The efficiency is exactly why. In the Template we need to reference this for each property to know whether or not we need an else, so it can get expensive to have to loop every time.
There was a problem hiding this comment.
Ah gotcha, definitely better this way then haha
Based on #268, fixes #266.