Skip to content

Support all text/* content types in responses #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Conversation

dbanty
Copy link
Collaborator

@dbanty dbanty commented Dec 4, 2023

Replaces #780.

Closes #797, #821

TODO:

  • Fix unnecessary cast

fdintino and others added 3 commits July 21, 2023 11:26
Responses with "Content-Type: text/csv" or "Content-Type: text/xml"
ought to be treated the same as text/html
# Conflicts:
#	openapi_python_client/parser/responses.py
@dbanty dbanty changed the title feat: Support all ` feat: Support all text/* content types Dec 4, 2023
@dbanty dbanty changed the title feat: Support all text/* content types Support all text/* content types Dec 4, 2023
@dbanty dbanty changed the title Support all text/* content types feat: Support all text/* content types in responses Dec 6, 2023
@dbanty dbanty changed the title feat: Support all text/* content types in responses Support all text/* content types in responses Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea4b545) 100.00% compared to head (57167c3) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #897   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         1918      1932   +14     
=========================================
+ Hits          1918      1932   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbanty dbanty merged commit 87b969c into main Dec 6, 2023
@dbanty dbanty deleted the fix-content-type-text branch December 6, 2023 22:18
github-merge-queue bot pushed a commit that referenced this pull request Dec 7, 2023
Resolves #588.

Thanks for a great tool! I hope this is compatible with the active work
going on in #897.

---------

Co-authored-by: Dylan Anthony <dbanty@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants