Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch license from Apache to MIT #211

Merged
merged 1 commit into from
Nov 21, 2020

Conversation

rwalle61
Copy link
Collaborator

@rwalle61 rwalle61 commented Nov 15, 2020

This is a one-time switch to MIT license, for the reasons below:

Motivations:

  • We are a Jest plugin and Chai plugin, so it makes sense for us to match the license of Jest and Chai, which is MIT.
  • This won't make much/any practical difference, as Apache and MIT are basically equally permissive.
  • MIT is much shorter to read, so easier to understand
  • MIT is a bit more popular in general and I think much more popular in the Jest / Chai / general JS testing space

Risks:

  • As I understand things, Apache is basically like MIT but (A) anyone who modifies this code will have to specify their modifications explicitly and (B) anyone wanting to patent something using this code will have explict permission to do so, whereas with the MIT license this is only heavily implied
  • Current users may not be happy with this switch (for the above reason or another I'm not aware of) and therefore stop using this package.

Sources:

Decision:

  • Leave this PR open for at least 1 week - if anyone objects to the license change, please downvote this and leave a comment explaining why
  • If there are no significant objections, publish this under a new minor version (we don't do major versions yet) to signify a change to users

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #211 (35b8bca) into master (6bc5ccb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #211   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        33           
  Lines          670       670           
  Branches        49        49           
=========================================
  Hits           670       670           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc5ccb...35b8bca. Read the comment docs.

@rwalle61 rwalle61 merged commit 899f6a0 into master Nov 21, 2020
@rwalle61 rwalle61 deleted the switch-license-from-apache-to-mit branch November 21, 2020 16:04
@rwalle61 rwalle61 mentioned this pull request Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant