feat, test, refactor: more useful assertion failure msgs #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat:
E.g. previously
expect(res).to.not.satisfyApiSpec
would fail ifres
matched no responses in your API spec.expect(res).to.not.satisfyApiSpec
meant "expectres
to match but not satisfy a response defined in your API spec".Now
expect(res).to.not.satisfyApiSpec
means "expectres
to neither match nor satisfy a response defined in your API spec". So ifres
matches no responses in your API spec, thenexpect(res).to.not.satisfyApiSpec
passes.test:
refactor:
assertions
dirValidationError
s instead of genericError
serror.message
through to the user, construct a more informative message at the chai assertion layer.Comparison: assertion failure messages now much more informative and more consistent with each other:
expect(response).to.satisfyApiSpec
:expect(object).to.satisfySchemaInApiSpec
: