Add integration test to the Issue #25 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the plugin is missing in the maven repo, the invoker plugin would not be able to pick it up, and the test build will fail.
this was meant to speed up first invoker executions, but in fact it is not needed.
|
Sorry, haven't forgot this just been incredibly busy at work. Thanks for making the integration test setup more robust - it really was a problem the tests running in the same VM as the build. Will get back as soon as possible. |
|
Finally got this merged.. Once again thanks for the contribution.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the integration test to the problem fixed in Issue #25.
As this problem heavily depends on maven classloading, ordinary IT is not an option for this case (at least I was not able to do it properly). Therefore, the integration test is performed by maven invoker plugin, which essentially takes a sample project and invokes specific maven goals on it (sample projects are located in stc/it, as this seems to be the maven invoker default option). The advantage is that the environment is exactly the same as with standard maven build.
The invoker ITs are only active if the "run-its" maven profile is activated. I did not alter your travis build in any way, so nothing should happen during the current travis build at this moment.
This pull request is a side effect of my attempt to fix Issue #25, and I thought you might find it useful. If you would like to take it or adapt it somehow, the thing to do here is probably to adjust the travis build to activate the "run-its" profile.