Handle GitHub API rate limits in script #2471
Conversation
|
✅ Deploy Preview for openapi-ts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
size-limit report 📦
|
htunnicliff
force-pushed
the
handle-gh-api-rate-limits
branch
3 times, most recently
from
fd68e4c to
a7660f2
Compare
htunnicliff
force-pushed
the
handle-gh-api-rate-limits
branch
from
a7660f2 to
493eee1
Compare
|
|
||
| if (process.env.GITHUB_TOKEN) { | ||
| request.headers.set('Authorization', `Bearer ${process.env.GITHUB_TOKEN}`) | ||
| } |
There was a problem hiding this comment.
Suggestion to make this non-optional once it is set as secret (or even set the secret right away, so you don't need to touch it anymore, up to you).
There was a problem hiding this comment.
I think leaving this conditional might make sense just in case, since the API will remain accessible even if we don't have a token(albeit at a more constrained rate limit).
|
|
||
| const res = await fetch(request); | ||
|
|
||
| if (!res.ok) { |
There was a problem hiding this comment.
Only do the rate-limit retry if we get a 429? (res.status === 429)?
There was a problem hiding this comment.
Normally I'd concur, but after reading the docs on handling rate limit errors appropriately, I think retrying in this manner should cover us.
| } | ||
|
|
||
| main(); | ||
| if (import.meta.main) { |
There was a problem hiding this comment.
Heh :) First time I see this in JS/TS.
There was a problem hiding this comment.
😄 it's the ESM equivalent of require.main === module
htunnicliff
force-pushed
the
handle-gh-api-rate-limits
branch
from
33948b7 to
413ca37
Compare
2 participants
Changes
Updated
fetchUserInfoto appropriately handle GitHub API rate limits.Notes
This should resolve issues we've encountered in Netlify builds (example).
I'm also going to add a token to our Netlify env vars to help increase our rate limits.