make status codes numeric

[jankuca]

Closes #380

[codecov]

Codecov Report

Merging #381 (7336095) into main (e73e0d3) will increase coverage by 0.52%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
+ Coverage   92.91%   93.43%   +0.52%     
==========================================
  Files           5        5              
  Lines         268      259       -9     
  Branches       90       84       -6     
==========================================
- Hits          249      242       -7     
  Misses         13       13              
+ Partials        6        4       -2     

Impacted Files	Coverage Δ
src/index.ts	81.81% <50.00%> (ø)
src/property-mapper.ts	84.21% <50.00%> (ø)
src/v2.ts	84.61% <87.50%> (+0.89%)	⬆️
src/v3.ts	96.89% <93.54%> (+0.63%)	⬆️
src/utils.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135a93b...7336095. Read the comment docs.

[gr2m]

great PR! @drwpow if you agree with the change, I think we should release this as a breaking change.

I'll test the change against my own work with @octokit to see if I run into any trouble, as I ran into the same problem you did

[gr2m]

This changes works well for my usage in @octokit. Accessing the responses works the same using ...["responses"]["200"]. The only difference is that keyof paths["..."]["get"]["responses"] returns 200 | 404 instead of "200" | "404"

I say let's go ahead with it. I'm not even sure if I would consider the change a breaking change, but when in doubt I'd always rather go with a breaking change.

[drwpow]

I'm not even sure if I would consider the change a breaking change, but when in doubt I'd always rather go with a breaking change.

Yeah I could go either way here. I think it technically is a breaking change, but it’s a breaking change on a newly-released feature. I agree with erring on the side of breaking change, and cutting 3.0 for this

[drwpow]

@all-contributors please add @jankuca for code, test

[allcontributors]

@drwpow

I've put up a pull request to add @jankuca! 🎉

[drwpow]

OK I tagged & released 3.0.0-rc.0 with these changes. If y’all have time to test the changes that’d be great! Overall I feel pretty confident in it, but just in case wanted to just kick the tires a bit before releasing 3.0.0.