remove deprecated support for max_bg and wide_bg_target_range #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any objections to this approach? Does anyone use these features? Does anyone want to post to FB to see if anyone there uses it? If no to all of those, I'll go ahead and merge it to dev. |
|
LGTM. I guess the subsequent pass after this is merged to refactor the code to only have one BG target (and update unit tests accordingly, need to continue on that). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wide BG target ranges result in worse outcomes than a single BG target (at a preferred point within the wider range), as they prevent OpenAPS from taking earlier action to correct high and/or low BG.
In order to simplify code paths, allow for easier testing, and make room for future improvements, this PR removes support for wide_bg_target_range and max_bg, and instead sets target to min_bg (which has been the default behavior for some time).
This PR does not (yet) deprecate separate high and low temporary targets, but that would be an obvious next step.