Upload NS status when possible. #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this checkin, ns-loop created the status data, and uploaded it to nightscout (if possible). But in case of failure, the file will get overwritten. This means that in the case of no internet, OAPS decisions get lost. This checkin fixes it by adding timestamps to the files. When internet is available, the files will be uploaded according to the correct order. Files older than a day will be deleted. Testing: I have prevented uploading of files for a few hours, and when it was enabled again, data was shown correctly in nightscout site. Decreased timeout, and saw the files being deleted. Signed-off-by: Tzachi Dar <tzachi.dar@gmail.com>
|
😍 How typical is it currently for the upload skipping to happen? Wondering about the impact on the amount of data sent to Nightscout, as this could impact the NS performance on many levels |
|
I guess that it depends on your network. Our rigs that are at home never miss an upload, and the one that are at school miss a few hours every week. |
scottleibrand
approved these changes
Jan 5, 2020
… of uploading it. Signed-off-by: Tzachi Dar <tzachi.dar@gmail.com>
|
Please note that I have added another commit to this pr. |
Closed
|
Tested and working well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this checkin, ns-loop created the status data, and uploaded it to nightscout (if possible).
But in case of failure, the file will get overwritten.
This means that in the case of no internet, OAPS decisions get lost.
This checkin fixes it by adding timestamps to the files.
When internet is available, the files will be uploaded according to the correct order.
Files older than a day will be deleted.
Testing:
I have prevented uploading of files for a few hours, and when it was enabled again, data was shown correctly in nightscout site.
Decreased timeout, and saw the files being deleted.
Signed-off-by: Tzachi Dar tzachi.dar@gmail.com