Installer fixes #1366
Merged
Installer fixes #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cluckj
commented
Feb 24, 2020
cluckj
commented
- Changes the way nodejs/npm are installed: Edison rigs will get it v8 from nodesource (Jessie/Stretch), Pi rigs will get it from the distro (Raspbian Buster)
- openaps toolchain will be installed from the latest version on git, rather than via pypi.
- Rework nodejs/npm install - Install openaps toolkit from github - Ask user to upgrade their Debian Jessie install...
This stores MEDTRONIC_PUMP_ID and MEDTRONIC_FREQUENCY in the user's ~/.bash_profile, so they can run commands without having to manually set them at login time.
| fi | ||
|
|
||
| # Upgrade npm to the latest version using its self-updater | ||
| sudo npm install npm@latest -g || die "Couldn't update npm" |
There was a problem hiding this comment.
What version will we end up with on each platform from this?
There was a problem hiding this comment.
This should install node v8 on the Edison (both Jessie & Stretch), node v8 on Pi's with Stretch, and node v10 on all Pi's with Buster. The version of npm should be the same across all platforms because it uses the self-updater.
scottleibrand
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.