Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app.py to show sgv via workaround #1391

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Conversation

Foxy7
Copy link
Contributor

@Foxy7 Foxy7 commented Jan 4, 2021

As per @renegadeandy pull request renegadeandy#1

just tested it and it works nicely, so making PR for Dev.

As per @renegadeandy pull request renegadeandy#1

just tested it and it works nicely, so making PR for Dev.
@scottleibrand
Copy link
Contributor

I don’t use the enlite and haven’t been closely following this issue. Can someone fill me in on what testing has been done to confirm this fixes the issue and doesn’t cause any issues for non-enlite users?

@Foxy7
Copy link
Contributor Author

Foxy7 commented Jan 5, 2021

Hi, i wasn't aware this was enlite related, or at least it isn't for me.

We're using Dexcom G6, Edison and a Medtronic 715 pump.

I've got two rigs running, one using xdrip+ (overnight) and the other xdrip-js (daytime). And neither local webpages have shown sgv data from nightscout since I've been using OpenAPS. The xdrip-js one does work via Logger if the rig is in range/carried around.

I added the line to both rigs last night and the xdrip+ one has worked, but i see the xdrip-js one hasn't.

I've not done any further testing, perhaps this should be an issue?

Screenshots from this morning, left picture is xdrip-js:

image

@scottleibrand
Copy link
Contributor

Sorry, I confused it with another issue. So this only affects the “offline” web page display on the rig?

@Foxy7
Copy link
Contributor Author

Foxy7 commented Jan 5, 2021

thanks @scottleibrand.

@Foxy7
Copy link
Contributor Author

Foxy7 commented Jan 5, 2021

to confirm, yes only affects the offline webpage.

@scottleibrand scottleibrand merged commit 1d9e5f5 into openaps:dev Jan 5, 2021
@Foxy7 Foxy7 deleted the patch-1 branch January 6, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants