Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

per #1401 ensure that halfBasalTarget is >=130 #1402

Closed
wants to merge 1 commit into from

Conversation

scottleibrand
Copy link
Contributor

As discussed in #1401 a halfBasalTarget of 120 causes a divide by zero, and halfBasalTarget <120 causes negative sensitivityRatio. Anything 121-129 would IMO cause the system to behave way too strongly to very slight changes in temp target, so I propose we hard-code the minimum halfBasalTarget to 130 mg/dL.

@SeregaYakovlev
Copy link

My autotune_max is 1.2 My ISF is 2.0. The minimum ISF is 2.0 / 1.2 = 1.7. The difference from the minimum ISF and default ISF is 0.3 for me.
ISF can have strongly difference only for children, but OpenAPS is not recommended for toddlers.
I think that the difference 0.5 will easy cover by low sensitivity on high sugar.
Consequently, I wish to limit the half_basal_exercise_target to 121.

@scottleibrand
Copy link
Contributor Author

Merged #1403 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants