-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewind, prime and battery indicates change #1409
Conversation
updated doc too. openaps/docs#1571 |
|
added filter for "fixed" primes only to count as site change. therefore manual primes will be ignored.
linke to doc update: openaps/docs#1571 |
example output:
|
Can you confirm (have you tested?) that this only affects pills on Nightscout, and doesn't affect OpenAPS behavior in any way? If so, I'll probably s/cartridge/reservoir/g and then go ahead and merge it. |
Nice, this solves a pain point for me (currently pump-site-change is the only thing I'm entering directly in Nightscout, everything else I enter through the pump). |
@jimrandomh can you test it from this branch and confirm the intended behavior? Or would I need to merge it to dev first? |
I'll be testing it (and don't need it merged to dev to do so). |
I have been using this for a week and it seems to be working correctly. It updates the pills in Nightscout in the expected way. |
Thanks both. yes to confirm only impacts NS pill, not OpenAPS at all. |
It's not working for me.
after mm-format-ns-treatments.sh format
whe I remove "and .type == "fixed" " from mm-format-ns-treatments.sh
|
@szymjaw this is correct, a "manual" prime won't trigger the NS eventType change and will only be shown as a note. This is because the usual process is that the medtronic pump is rewound, the tubing is manually primed and finally a 0.3 fixed prime (infusion set dependent) is used to fill the cannula. Hences the code only picks up two events, rewind and fixed prime. In the past we have used manual prime to add insulin which won't be counted by OpenAPS, e.g. after the pump was disconnected for a shower, we'd do a small manual prime to make up for missed insulin without OpenAPS double counting. |
Added optional preferences to enable automatice update of Cannula, Insulin and Battery Age on Nightscout.