-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Make glucose-get-last faster #1468
Open
thomasvargiu
wants to merge
1
commit into
openaps:dev
Choose a base branch
from
thomasvargiu:faster-glucose-get-last
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+27
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasvargiu
changed the title
Make glucose-get-last extremely faster
Make glucose-get-last faster
May 4, 2024
Do you have a time estimate of the gain @thomasvargiu ? |
@mountrcg not really. I tried it on iAPS, I thought it was very slow but currently it isn't a real problem... |
Jon-b-m
added a commit
to Artificial-Pancreas/iAPS
that referenced
this pull request
May 9, 2024
thomasvargiu
changed the title
Make glucose-get-last faster
WIP: Make glucose-get-last faster
May 9, 2024
thomasvargiu
force-pushed
the
faster-glucose-get-last
branch
from
May 9, 2024 15:04
0701774
to
c1729c0
Compare
Jon-b-m
added a commit
to Artificial-Pancreas/iAPS
that referenced
this pull request
Jun 25, 2024
* Use a faster glucose-get-last Commit openaps/oref0#1468, by @thomasvargiu * Crowdin updates (#666) * Release Reminder (#667) * Crowdin updates (#668) * Fix time check * Position of sharing link * Fix for version uploads and requests (#669) * New string * change path * Crowdin updates (#671) * Crowdin updates * Remove unnecessary conversion Nightscout (#672) * Sharing View UI edits. * Crowdin updates (#674) * Crowdin translations (#675) * Dev updates (#676) * Crowdin updates (#677) * Crowdin (#678) * Decrease frequency * IOB correction * Contact Image - small optimizations (#683) * Contact Image - don't do anything if no contacts configured or access to contacts is not granted * Contact Image - only save contacts in store if they get changed * Update add_identifiers.yml Xcode15/Node 20 support * Update build_iAPS.yml Xcode 15.3 * Update create_certs.yml Xcode 15.3/Node 20 * Update validate_secrets.yml Xcode 15.3/Node 20 * Update Gemfile.lock New versions * Crowdin translations * Sync IOB count for overrides * Always log and display in pop-up when dynISF disabled by exercise * Missing bracket (cherry picked from commit 6743fc5) * Allow for bigger individual adjustments of the FPU settings. * Don't force-unwrap * Active Insulin/Carbohydrates Charts (#690) * New Crowdin updates (#684) * Crowdin updates (#684) (#692) * Delete reference * Save settings and preferences and profiles to stat database (#698) * Share settings and profiles * Share Settings and Preferences * Log the middleware errors and display in pop-up. (#699) * Crowdin updates (#695) * Crowdin (#700) * New Crowdin updates (#684) * Crowdin updates (#695) * Crowdin updates (#707) * Crowdin (#709) * Contact Image - fix for contacts not being saved into storage when the contact ID is already defined (#705) * Basal Adjustment. Remove extra characters (#708) * NS URL should not be needed for stat uploads * NS URL not needed for stats uploads 2/2 * Resolve issue #712 (#715) * Remove type conversion (resolves issue #712) (Swift bug?) * Crowdin updates (#714) Vietnamese by Hung Nguyen * Crowdin (#716) * New Crowdin updates (#684) * Crowdin updates (#695) * Crowdin updates (#707) * Crowdin updates (#714) Vietnamese by Hung Nguyen * Dev updates (#717) * Temporary quick fix for RepeatingScheduleValue (#718) "Resolves" issue #711 * Fix Typo: birtDate -> birthDate (#722) Set default birthDate to distantPast ( current default is "today", making everyone an infant ) * fix: Use the pump limits from the pumpManager instead the user provided one (#720) * Crowdin updates (#721) * Overdue update to the iPhone identifier list (#725) * Insulin and TDD details. (#724) * Insulin and TDD details. Also use autosens.min/max for dynamic basal* Increase vertical spacing * Missing localizable strings. OmniBLE * Crowdin updates (#730) * New Crowdin updates (#731) * Add link to sharing to bring directly to personal statistics page (#727) * Add link to sharing to bring directly to personal statistics page, with token * remove general statistics url in favor of user statistics this put their token into a session on the statistic server, so that any page that can make use of it ( full list / sigmoid list ) will show their entry, but the long term goal for that landing page is to be able to allow users to view settings ( ie. to print / save ), and eventually, provide a more complete settings editor then nightscout provided ... * Crowdin updates (#733) * confirm pod DeliveryStatus to prevent 0x31 fault (#735) * New Crowdin updates (#736) * Complete the carbs -> bolus flow before enacting any eventual auto bolus (SMB) or any auto temp basal. (#706) Prevent SMBs and temp basals (over 0u) while in Bolus View, but If more than 30 minutes since last loop - force close the bolus view * Use NS URL for NS uploads * Allow bolus when long time since last loop * New Crowdin updates (#739) * Don't require a NS URL for the version check * Bump version * New translations localizable.strings (Russian) (#741) --------- Co-authored-by: Mike Plante <82073483+MikePlante1@users.noreply.github.com> Co-authored-by: yurique <i@yurique.com> Co-authored-by: Marc G. Fournier <scrappy@hub.org> Co-authored-by: Bastiaan Verhaar <3987804+bastiaanv@users.noreply.github.com> Co-authored-by: Marion Barker <marionbarker@earthlink.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
glucose-get-last
extremely with minimum loops and ignoring older useless data.