Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.6.1 release dev to master #816

Merged
merged 122 commits into from
May 15, 2018
Merged

0.6.1 release dev to master #816

merged 122 commits into from
May 15, 2018

Conversation

danamlewis
Copy link
Contributor

@danamlewis danamlewis commented Nov 26, 2017

0.6.1-rc1:

Many minor fixes & improvements.

Notable:
• x12 fixes
• limit SMB zero temps to 60 minutes
• offline web page
• raise BG target for noisy / raw CGM data (#833)
• autosens is always enabled (to disable, set min/max to 1)
• faster autotune; and avoids raising basals from UAM carbs
• added cleaning to address full diskspace issues
• Carelink support re-added
• Suspends will count as zero IOB; no longer need to temp to zero and suspend (but people should make sure to change their settings for suspend-if-no-temp if they leave this as false, so pumps don't get unsuspended and issue SMB's while they're still disconnected)
• No longer warns in logs (causing excessive buildup) about DIA of 2 < 3. Defaults to 5, regardless, for curves, since 0.6.0

Copy link
Contributor

@scottleibrand scottleibrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking with Request changes until we're ready to merge.

scottleibrand and others added 24 commits November 25, 2017 19:08
…upstream. Only warn if repo is ahead of local (not local ahead of remote) (#822)
changed splice/pop to array element
cleaned up ns-status
* Check OREF0_SRC env for source code location. Check for being behind upstream. Only warn if repo is ahead of local (not local ahead of remote)

* Need to actually git fetch upstream

* Update oref0-version.sh

Clarify error message
* Process the Meal marker event from medtronic pump (#810)

* Changes

* Process Meal Markers from pump

* Undo changes

* tabs to spaces to fix indentation

* return journalCarbs

* copy-pasta fix

* indentation
…826)

* Improve the oref0-pump-loop debuginng options by adding a debug flag.

* Grammar
* commenting out unused and incorrect prepped_glucose code

* remove second (yet) for consistency

* remove second (yet) for consistency

* not above means <=
* Basal record search (#819)

* Changes

* Search through pump history for basal duration records

* undoing some changes

* Missed variable rename

* Attempt to fix failing tests, they're referring to 'date' not 'timestamp'

* loop over all of pumpHistory to find matching TempBasalDuration if it's not adjacent

* fix whitespace (tabs and trailing spaces)
regenerate-index.sh creates a new file index.html every time it is run.  This contains simple html formatting with example data for now (intent is to add additional parameter-value pairs for display after approval of proof of concept).
setup-http.sh is intended to be called from oref0-setup.sh and adds cron entries to start SimpleHTTPServer at reboot and run regenerate-index.sh periodically.  Both files should be in ~/myopenaps/enact directory.  From a browser on any device, browse to http://[RIG_IP_ADDRESS]/index.html and the page will self-refresh periodically.
* Fix typo in setup script for 512 files

Script currently saves 'bg_targets_raw.json' as 'bg_targets_raw.json,'

Remove the errant comma at the end of the output file name.

* Fix the other one too
* ask about Explorer Board HAT

* install explorer-hat branch of spi-serial for spidev0.0

* merged pi-install to dev

* pi user

* switch to decocare-clean

* enable spidev ports on the Pi

* try using packaged bluez with Rapsbian

* force apt to use IPv4 for now

* set bluetoothdminversion=5.43 to use packaged bluez with Rapsbian

* Revert "switch to decocare-clean"

This reverts commit 77dbd8a.

* switch to oref0/master for bin/openaps-packages.sh
@M1Sports20
Copy link

Filling comments as requested by dana from gitter.
All has been well with this dev build. My setup:
Two rigs, both identical:
Rig: edision with explorer board
Pump: Medtronic 523
Timezone: Eastern
Time: Started 4-20-18
Target: 90
Settings:

"max_iob": 10,
"max_daily_safety_multiplier": 3,
"current_basal_safety_multiplier": 4,
"autosens_max": 1.2,
"autosens_min": 0.7,
"rewind_resets_autosens": true,
"adv_target_adjustments": false,
"exercise_mode": true,
"wide_bg_target_range": false,
"sensitivity_raises_target": true,
"unsuspend_if_no_temp": true,
"enableSMB_always": true,
"enableSMB_with_bolus": true,
"enableSMB_with_COB": true,
"enableSMB_with_temptarget": true,
"enableSMB_with_carbs": true,
"enableUAM": true,
"curve": "rapid-acting",
"offline_hotspot": false,
"maxSMBBasalMinutes": 45

jimrandomh and others added 2 commits April 27, 2018 16:52
Fix a typo that would cause completed_recently in oref0-autosens-loop.sh to always be false. This effectively disabled a feature that was supposed to make autosens recalculation happen less frequently when under high load.
Revert the outcome of this test to its original behavior.
@cluckj
Copy link
Contributor

cluckj commented Apr 29, 2018

From-scratch x12 setup & docs worked for me. Can anyone else with an x12 check this as well?

@danamlewis
Copy link
Contributor Author

Just marked this as 0.6.1-rc1. As a reminder, we need lots of help testing this to get a release, so please check out a fresh dev (instructions here, follow steps 1A, 2, and 3) and make sure to comment on this PR to let us know how it's going. Thanks to everyone who's tested & commented so far!

@AdrianLxM
Copy link
Contributor

maxRaw seems to be written to but never used within determine-basal:

// don't allow maxRaw above 250

I also could not find any changes in 0.7.0 that would use it. All raising of targets etc. is done implicitly via adding a noise value in lib/with-raw-glucose.js

@TwistaTim

This comment has been minimized.

@scottleibrand

This comment has been minimized.

Add -y flags to the rest of the apt-get commands to bypass y/n prompts.
@TwistaTim

This comment has been minimized.

@TwistaTim

This comment has been minimized.

Same issue as last, different location.
Copy link
Contributor

@TwistaTim TwistaTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works....

@danamlewis
Copy link
Contributor Author

Reminder - please test dev and comment on your setup. Expecting to release 0.6.1 end of this week if no major issues are spotted. See here for the list of things to test for this release.

To test, check out a fresh dev (instructions here, follow steps 1A, 2, and 3) and make sure to comment on this PR to let us know how it's going.

@TwistaTim
Copy link
Contributor

Given the latest 0.6.1 pull a try with the latest fix for TT in mmol being issued, works well.
Seems like this is ready for release to me 🎉

@TwistaTim
Copy link
Contributor

MaxUAMSMBBasalMinutes is working wonderfully! Graph with it in action!
Awesome stuff @scottleibrand and @danamlewis 👍
smbfeature

@tynbendad
Copy link
Contributor

i tried latest dev on a backup rig and it was working well until we used it for a full day - the rig hung twice (as in unresponsive, even thru serial port). i plan to try it on another rig shortly, its unlikely that its related to changes in dev, but thought i should post just in case.

@danamlewis
Copy link
Contributor Author

I asked on Gitter for some European time zone testers. On Gitter, @CaptainBalou said "I am using this branch and I am update frequently. I am in Europe with CEST time zone. I had not issues which prevented me from normal looping. Setup is Veo 754, xdrip, G5."

so that sounds like a 👍 for non-NA time zones, xdrip, etc.

@tim2000s
Copy link
Contributor

Although I’ve not run the RC I am running the dev that led to the rc. My only comment is that all my data in NS is 24 hours behind, but I think this is a heroku or Mlab issue.

@PieterGit
Copy link
Contributor

PieterGit commented May 14, 2018

@danamlewis : using a version without the latest few commits for quite some time with Veo 754, G4-USB, WW-pump and EU timezone. No problems. Quite stable.

Only problem is that newest explorer boards seem with dev branch seem too hang when I plug in the main power in the powerpack and there is no lipo attached to the explorerboard. I think that used to be ok (with oref0 0.5.x and older revision of the Explorer board). Will try to investigate, but not much oref0 time available these weeks. This is no blocker for a new release afaict.

@danamlewis danamlewis dismissed scottleibrand’s stale review May 15, 2018 19:13

removing hold as we are ready for 0.6.1 release

@danamlewis danamlewis changed the title Prep for 0.6.1 release dev to master 0.6.1 release dev to master May 15, 2018
@danamlewis danamlewis merged commit 749377a into master May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.