This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Updated github.com/go-sql-driver/mysql to the master HEAD. #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
very interesting indeed. |
|
@maurosr can you kindly ping me after this had been deployed at your company for a few days in production? I like nothing better than knowing this runs successfully on X,000 servers. |
|
Will do (3 hours running in production by now and is looking good). |
|
@shlomi-noach everything looks fine in production with the driver upgrade. |
|
Ok cool. I'll merge shortly |
|
Sorry, forgot to make a new branch for TLS. I'll revert and create another PR for that. |
This reverts commit 8a505fb.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug go-sql-driver/mysql#536 so now the same TLS config does not need to be registered for each host and with different name (I am working on the ability to have mixed TLS and non-TLS connections to different nodes of the topology).
Also, an interesting effect noticed: after the upgrade of the driver there was a 20% decrease of median poll time to orchestrator backend.