This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Instance write buffer metrics v2 #682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the following api calls * /api/instance-buffered-write-metrics-raw/:seconds * /api/instance-buffered-write-metrics-aggregated/:seconds
* also change collection name strings to constants
mateusduboli
force-pushed
the
instance-write-buffer-metrics-v2
branch
from
53abffd to
3519e0f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Pull Request should be associated with an Issue.
Related issue: #113
Description
This is an alternative implementation of #676. The other code relied on a collection to store individual values and later create statistics about them. This implementation relies only on go-metrics to do this.
For this to be more elegant this also splits the instance_write_buffer from the instance_dao, to split the metric generation and reduce the general size of the instance_dao file.
gofmt(please avoidgoimports)./build.shgo test ./go/...