Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

implement to get the cluster_domain for {failureClusterDomain} #970

Merged
merged 6 commits into from
Nov 5, 2019

Conversation

tom--bo
Copy link
Contributor

@tom--bo tom--bo commented Aug 26, 2019

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.

Related issue: #969

Thank you! We are open to PRs, but please understand if for technical reasons we are unable to accept each and any PR

Description

  • Add cluster_domain column at SELECT_LIST in GetReplicationAnalysis()'s query.
  • Set it to ClusterDetails.ClusterDomain.

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • code is formatted via gofmt (please avoid goimports)
  • code is built via ./build.sh
  • code is tested via go test ./go/...

No test code for this, but I already deployed my company's test-environment and there is no problem.

Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this PR looks good.

@mostafahussein
Copy link

@tom--bo is this issue that you are trying to solve is the reason behind a new cluster is created when a master is dead and a slave promoted to master ?

@shlomi-noach
Copy link
Collaborator

Sorry about the delay; I expect to look into & merge a bunch of community PRs during the first two weeks of October.

@tom--bo
Copy link
Contributor Author

tom--bo commented Sep 29, 2019

@mostafahussein Sorry about late reply.

@tom--bo is this issue that you are trying to solve is the reason behind a new cluster is created when a master is dead and a slave promoted to master ?

This PR may not match your situation...
Please see the issue #969 which I want to solve by this PR

@openark openark deleted a comment Oct 7, 2019
@openark openark deleted a comment Oct 7, 2019
@shlomi-noach shlomi-noach merged commit 9a75f0b into openark:master Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants