Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply changes from 1.3.9 with errata of 2021-06-30 to swiss-ng-api ba… #53

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

adejung
Copy link
Collaborator

@adejung adejung commented Sep 15, 2021

First draft of the changes applied to the swiss-ng-api

Some questions are open.

@adejung
Copy link
Collaborator Author

adejung commented Sep 16, 2021

  • Can we replace the otherAccountIdentification1-CH with the new otherType? (line 4353 swiss-ng-api.yaml)
  • creditorAgentName changed from maxLength 70 to 140, we got 35 defined. What should we take?
  • serviceLevelCode is newly introduced, we got externalServiceLevel1Code defined with a subset of values. Can we switch to serviceLevelCode? (line 6086, 6236, 6390)
  • Commented properties options from psd2-api are not shown in swiss-ng-api e.g. paymentInitiationWithStatusResponse line 6804. Therefore we do not update changes of commented properties?

@adejung adejung requested review from blehers and chatelao September 16, 2021 07:49
@blehers
Copy link
Collaborator

blehers commented Nov 30, 2021

As discussed, I suggest that until the publication of the Berlin Group's Payment Data Model v2 (expected in a few weeks), we only adjust something if urgently needed. The functional alignment with the new data types has already been done and will make the Switzerland-specific data types redundant.

  • Can we replace the otherAccountIdentification1-CH with the new otherType? (line 4353 swiss-ng-api.yaml)

no urgent need for action known

* creditorAgentName changed from maxLength 70 to 140, we got 35 defined. What should we take?

no urgent need for action known

* serviceLevelCode is newly introduced, we got externalServiceLevel1Code defined with a subset of values. Can we switch to serviceLevelCode? (line 6086, 6236, 6390)

no urgent need for action known

* Commented properties options from psd2-api are not shown in swiss-ng-api e.g. paymentInitiationWithStatusResponse line 6804. Therefore we do not update changes of commented properties?

no urgent need for action known

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants