Merge branch 'obs_lite'

openbikesensor · Sep 16, 2024 · 9d257bd · 9d257bd
2 parents 17d4a9d + c6c378e
commit 9d257bd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/customizer/src/obs_case_customizer/app.py b/customizer/src/obs_case_customizer/app.py
@@ -307,6 +307,10 @@ class CustomVariables(BaseModel):
     SeatPostMount_diameter: float = Field(28, title='in mm', ge=15, le=35)
     SeatPostMount_length: float = Field(20, title='in mm', ge=15, le=120)
     HandlebarRail_tube_radius: float = Field(18, title='in mm', ge=10, le=30)
+    DisplayCase_outer_width: float = Field(30.0, title='in mm', ge=28, le=34)
+    DisplayCaseTop_window_width: float = Field(21.5, title='in mm', ge=20, le=24)
+    DisplayCaseTop_window_height: float = Field(12.5, title='in mm', ge=10, le=15)
+    DisplayCaseTop_window_offset: float = Field(2, title='in mm from bottom', ge=0, le=5)
     DisplayCaseTop_pcb_width: float = Field(26.5, title='in mm', ge=25, le=29)
     DisplayCaseTop_pcb_height: float = Field(27.2, title='in mm', ge=25, le=29)
     DisplayCaseTop_pcb_standoff: float = Field(1.7, title='in mm', ge=0.5, le=2)

diff --git a/src/DisplayCase/DisplayCaseTop.scad b/src/DisplayCase/DisplayCaseTop.scad
@@ -80,7 +80,7 @@ module DisplayCaseBasicShape(height=20, magnet_depth) {
           translate([DisplayCase_outer_radius, -DisplayCase_outer_radius, 0])
           cylinder(r=DisplayCase_outer_radius, h=height);
 
-          translate([25, -DisplayCase_outer_radius, 0])
+          #translate([DisplayCase_outer_width-4, -DisplayCase_outer_radius, 0])
           cylinder(r=DisplayCase_outer_radius, h=height);
 
           translate([DisplayCase_outer_width - DisplayCase_outer_large_radius, -45, 0])
@@ -117,7 +117,7 @@ module DisplayCaseBasicShape(height=20, magnet_depth) {
 
 module DisplayCaseHolePattern() {
   translate([DisplayCase_outer_radius, -DisplayCase_outer_radius])children();
-  translate([25, -DisplayCase_outer_radius])children();
+  translate([DisplayCase_outer_width-4, -DisplayCase_outer_radius])children();
   translate([DisplayCase_outer_radius+2, -(DisplayCase_outer_radius+DisplayCaseTop_pcb_height+DisplayCaseTop_hole_diameter+1)])rotate([0, 0, 180])children();
 }
 

diff --git a/src/LiteCase/LiteCase.scad b/src/LiteCase/LiteCase.scad
@@ -215,6 +215,7 @@ rotate([0,180,0])translate([-30,0,-Lite_ESP_position_z-0.8])difference() {
 
   translate([40, 0, Lite_ESP_position_z + 0.8+49.95])cube([120, 90, 100], center = true);
 }
+for (i=[-8,8]) translate([-40,i,0])cylinder(r=4,h=0.2);
 
 rotate([0,180,0])translate([-30,40,Lite_ESP_position_z-lite_l/2+1.6])intersection() {
   lite_case();