Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: BMCWEB_ENABLE_DBUS_REST=ON enables information leak #114

Closed
feistjj opened this issue Feb 12, 2020 · 1 comment · Fixed by ibm-openbmc/bmcweb#69
Closed

Security: BMCWEB_ENABLE_DBUS_REST=ON enables information leak #114

feistjj opened this issue Feb 12, 2020 · 1 comment · Fixed by ibm-openbmc/bmcweb#69

Comments

@feistjj
Copy link
Member

feistjj commented Feb 12, 2020

Rest D-BUS allows lower privileged users to gain access to privileged information by direct D-Bus access. The default of this should be disabled.

@feistjj
Copy link
Member Author

feistjj commented Feb 13, 2020

aahmed-2 added a commit to aahmed-2/bmcweb that referenced this issue Aug 16, 2021
REST D-Bus, while providing useful functionality, also allows
authenticated users access to privileged information that may be above
their permission level. This change sets the default to disabled. Users
if they wish can turn it back on in their own layers.

A lot of functionality previously provided by REST D-Bus is now
available on Redfish with more coming all the time.

Note: phosphor-webui uses the REST D-Bus so a user of that will have to
enable this in their layer. webui-vue, the replacement for
phosphor-webui, uses Redfish. See here [1].

Resolves openbmc/bmcweb/issues/114

[1] https://github.com/openbmc/webui-vue

Tested: Rest D-Bus was disabled

Change-Id: I35682b113287b3be4e19b033d0296790b204d8e0
Signed-off-by: James Feist <james.feist@linux.intel.com>
Signed-off-by: Ali Ahmed <ama213000@gmail.com>
rfrandse pushed a commit to ibm-openbmc/bmcweb that referenced this issue Aug 17, 2021
REST D-Bus, while providing useful functionality, also allows
authenticated users access to privileged information that may be above
their permission level. This change sets the default to disabled. Users
if they wish can turn it back on in their own layers.

A lot of functionality previously provided by REST D-Bus is now
available on Redfish with more coming all the time.

Note: phosphor-webui uses the REST D-Bus so a user of that will have to
enable this in their layer. webui-vue, the replacement for
phosphor-webui, uses Redfish. See here [1].

Resolves openbmc/bmcweb/issues/114

[1] https://github.com/openbmc/webui-vue

Tested: Rest D-Bus was disabled

Change-Id: I35682b113287b3be4e19b033d0296790b204d8e0
Signed-off-by: James Feist <james.feist@linux.intel.com>
Signed-off-by: Ali Ahmed <ama213000@gmail.com>
aahmed-2 added a commit to aahmed-2/bmcweb that referenced this issue Sep 2, 2021
REST D-Bus, while providing useful functionality, also allows
authenticated users access to privileged information that may be above
their permission level. This change sets the default to disabled. Users
if they wish can turn it back on in their own layers.

A lot of functionality previously provided by REST D-Bus is now
available on Redfish with more coming all the time.

Note: phosphor-webui uses the REST D-Bus so a user of that will have to
enable this in their layer. webui-vue, the replacement for
phosphor-webui, uses Redfish. See here [1].

Resolves openbmc/bmcweb/issues/114

[1] https://github.com/openbmc/webui-vue

Tested: Rest D-Bus was disabled

Change-Id: I35682b113287b3be4e19b033d0296790b204d8e0
Signed-off-by: James Feist <james.feist@linux.intel.com>
Signed-off-by: Ali Ahmed <ama213000@gmail.com>
aahmed-2 pushed a commit to aahmed-2/bmcweb that referenced this issue Sep 13, 2021
REST D-Bus, while providing useful functionality, also allows
authenticated users access to privileged information that may be above
their permission level. This change sets the default to disabled. Users
if they wish can turn it back on in their own layers.

A lot of functionality previously provided by REST D-Bus is now
available on Redfish with more coming all the time.

Note: phosphor-webui uses the REST D-Bus so a user of that will have to
enable this in their layer. webui-vue, the replacement for
phosphor-webui, uses Redfish. See here [1].

Resolves openbmc/bmcweb/issues/114

[1] https://github.com/openbmc/webui-vue

Tested: Rest D-Bus was disabled

Change-Id: I35682b113287b3be4e19b033d0296790b204d8e0
Signed-off-by: James Feist <james.feist@linux.intel.com>
Signed-off-by: Ali Ahmed <ama213000@gmail.com>
aahmed-2 pushed a commit to aahmed-2/bmcweb that referenced this issue Sep 16, 2021
REST D-Bus, while providing useful functionality, also allows
authenticated users access to privileged information that may be above
their permission level. This change sets the default to disabled. Users
if they wish can turn it back on in their own layers.

A lot of functionality previously provided by REST D-Bus is now
available on Redfish with more coming all the time.

Note: phosphor-webui uses the REST D-Bus so a user of that will have to
enable this in their layer. webui-vue, the replacement for
phosphor-webui, uses Redfish. See here [1].

Resolves openbmc/bmcweb/issues/114

[1] https://github.com/openbmc/webui-vue

Tested: Rest D-Bus was disabled

Change-Id: I35682b113287b3be4e19b033d0296790b204d8e0
Signed-off-by: James Feist <james.feist@linux.intel.com>
Signed-off-by: Ali Ahmed <ama213000@gmail.com>
rfrandse pushed a commit to ibm-openbmc/bmcweb that referenced this issue Sep 23, 2021
REST D-Bus, while providing useful functionality, also allows
authenticated users access to privileged information that may be above
their permission level. This change sets the default to disabled. Users
if they wish can turn it back on in their own layers.

A lot of functionality previously provided by REST D-Bus is now
available on Redfish with more coming all the time.

Note: phosphor-webui uses the REST D-Bus so a user of that will have to
enable this in their layer. webui-vue, the replacement for
phosphor-webui, uses Redfish. See here [1].

Resolves openbmc/bmcweb/issues/114

[1] https://github.com/openbmc/webui-vue

Tested: Rest D-Bus was disabled

Change-Id: I35682b113287b3be4e19b033d0296790b204d8e0
Signed-off-by: James Feist <james.feist@linux.intel.com>
Signed-off-by: Ali Ahmed <ama213000@gmail.com>
rfrandse pushed a commit to ibm-openbmc/bmcweb that referenced this issue Oct 14, 2021
REST D-Bus, while providing useful functionality, also allows
authenticated users access to privileged information that may be above
their permission level. This change sets the default to disabled. Users
if they wish can turn it back on in their own layers.

A lot of functionality previously provided by REST D-Bus is now
available on Redfish with more coming all the time.

Note: phosphor-webui uses the REST D-Bus so a user of that will have to
enable this in their layer. webui-vue, the replacement for
phosphor-webui, uses Redfish. See here [1].

Resolves openbmc/bmcweb/issues/114

[1] https://github.com/openbmc/webui-vue

Tested: Rest D-Bus was disabled

Change-Id: I35682b113287b3be4e19b033d0296790b204d8e0
Signed-off-by: James Feist <james.feist@linux.intel.com>
Signed-off-by: Ali Ahmed <ama213000@gmail.com>
gtmills pushed a commit to gtmills/bmcweb that referenced this issue Dec 12, 2022
REST D-Bus, while providing useful functionality, also allows
authenticated users access to privileged information that may be above
their permission level. This change sets the default to disabled. Users
if they wish can turn it back on in their own layers.

A lot of functionality previously provided by REST D-Bus is now
available on Redfish with more coming all the time.

Note: phosphor-webui uses the REST D-Bus so a user of that will have to
enable this in their layer. webui-vue, the replacement for
phosphor-webui, uses Redfish. See here [1].

Resolves openbmc/bmcweb/issues/114

[1] https://github.com/openbmc/webui-vue

Tested: Rest D-Bus was disabled

Change-Id: I35682b113287b3be4e19b033d0296790b204d8e0
Signed-off-by: James Feist <james.feist@linux.intel.com>
Signed-off-by: Ali Ahmed <ama213000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant