Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove randomization in unit tests #1

Open
edtanous opened this issue Jul 12, 2024 · 0 comments
Open

Remove randomization in unit tests #1

edtanous opened this issue Jul 12, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@edtanous
Copy link
Contributor

There's randomization currently in unit tests. For fuzz-type use cases, this should be moved to a real fuzzer (AFL or similar).

It's also very likely that we could just fuzz the entire address space in a unit test. We should avoid randomization that isn't selectable, as it's lead to hard-to-reproduce bugs.

@edtanous edtanous added the enhancement New feature or request label Jul 12, 2024
geissonator pushed a commit that referenced this issue Aug 6, 2024
An example that was flagged from the app that uses libcper:
'''
Indirect leak of 96 byte(s) in 2 object(s) allocated from:
    #0 0x7f93e0ddafdf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x7f93e0b97cde in json_object_new /json-c-json-c-0.17-20230812/json_object.c:321
    #2 0x7f93e0b97cde in json_object_new_object /json-c-json-c-0.17-20230812/json_object.c:532
    #3 0x7f93e0c8ac81 in cper_to_ir ../subprojects/libcper/cper-parse.c:45
'''

Change-Id: I6c77cf797bb369d6e459545cf021f31c47dbe6a0
Signed-off-by: Karthik Rajagopalan <krajagopalan@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant