Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html.tpl - Html Module. #2811

Closed
aWeirdo opened this issue Mar 24, 2015 · 1 comment
Closed

Html.tpl - Html Module. #2811

aWeirdo opened this issue Mar 24, 2015 · 1 comment

Comments

@aWeirdo
Copy link

aWeirdo commented Mar 24, 2015

Hi,
First off, I'm sorry,
but i have no clue how all that pull request and stuff works..
Minor bug, but annoying to look at.

When adding custom HTML code to your webstore via the HTML module,
if you don't need a heading title for your code, the module still adds a empty <h2></h2>, which leaves very a ugly space.

File: upload/catalog/view/theme/default/template/module/html.tpl

Current code:

<div>
<h2><?php echo $heading_title; ?></h2>
<?php echo $html; ?></div>

Fix:

<div>
<?php if(!$heading_title){} else { ?>
<h2><?php echo $heading_title; ?></h2>
<?php } echo $html; ?></div>

123 and that ugly space is gone.

Keep up the good work!, just started using opencart, loving it :) 👍

@beifloyd beifloyd mentioned this issue Mar 24, 2015
@beifloyd
Copy link

I don't think they accept code from here.
pull request created for you here #2813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants