Some fixes in default config values #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 1, 2014 21:44
There was no default value for config_image_location. image_location_width and image_location_height are required fields in store settings (store_form.tpl)
ghost
changed the title
ghost
changed the title
added 2 commits
July 2, 2014 00:04
jamesallsup
added a commit
that referenced
this pull request
Jul 16, 2014
Some fixes in default config values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were no default values for
config_image_location_{width|height}(required fields in store settings, admin panel)Incorrect default paths to logo.png and cart.png files were fixed, so now
config->get('config_logo')andconfig->get('config_icon')work properly.