Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18next-xhr-backend is deprecated #457

Open
JulianKniephoff opened this issue Feb 8, 2021 · 0 comments · May be fixed by #621
Open

i18next-xhr-backend is deprecated #457

JulianKniephoff opened this issue Feb 8, 2021 · 0 comments · May be fixed by #621

Comments

@JulianKniephoff
Copy link
Member

See i18next/i18next-xhr-backend#348 (comment) and https://github.com/i18next/i18next-http-backend.

This came up during #138.

JulianKniephoff added a commit to JulianKniephoff/annotation-tool that referenced this issue Dec 20, 2023
Not all of the libraries we were using could be found
(in the correct version) in NPM, so had to get creative
with some of them.

I tried to stick to our current versions as closely as possible,
except for some that were easy to update. Thus, most versions are
pinned instead of using the usual `^x.y.z` constraint.

Here are the detailed notes about where dependencies (might have)
changed:

* `vis-timeline` should be in the correct version, but the NPM build
  is a few moments younger, and differs slightly. I hope it's just
  variable naming or something like that, but comparing minified JS
  is hard, so I'm not 100% sure.
* `jquery.colorPicker` (or rather `really-simple-colorpicker` as the
  NPM package is called) is newer, because the original version isn't
  in NPM. Our use of it is relatively isolated, though, and it still
  seems to work superficially, so I'm relatively confident that this
  is fine.
* `jquery.appear` was never actually in use, so I removed it.
* `jquery` itself is updated to `1.8.2`. We were on `1.8.0` which is
  not in NPM. `1.8.2` is, and that should be fine, but jQuery is one
  of these candidates that you can never really be sure about since it
  doesn't follow SemVer perfectly and is used so pervasively, that
  even checking all our usages against the changelog is basically
  impossible.
* `i18next-xhr-backend` was replaced with (the newest version of)
  `i18next-http-backend`. The former is deprecated and not in NPM
  anymore, but the update here is literally a drop in replacement,
  apparently.
* Our Bootstrap version (2.3.2) is so dead it's not even funny.
  No `2.x` release is in NPM. Fortunately in this case one can just
  install it directly from their GitHub using the appropriate tag,
  but this is a bit shady and I want to get rid of it sooner rather
  than later. Unfortunately upgrading Bootstrap is a rather invasive
  step.
* The Bootstrap slider thing we were using doesn't even have a GitHub.
  I replaced it with one that does, and which is based on our original
  one. I used the oldest release they have on GitHub, and seems to be
  more or less the same, still, but there have been significant code
  changes between the two. As with the color picker, this is a rather
  isolated thing, though, so we should be fine?
* The RequireJS `text` plugin wasn't used anymore, so I got rid of it.
* RequireJS `domReady` only has newer versions in NPM, but they seem
  to work fine, even though there was a major jump here.
* `moment` got a minor update because the version we were using was
  actually incompatible with our `vis-timeline` version, and our own
  few uses should still work exactly the same. Note that this is
  merely a convenience to make `npm install` work. We are using
  all of these libraries pre-bundled, so `vis-timeline` isn't actually
  using the version of `moment` we are including, but rather comes
  with its own.

Fixes opencast#138.
Fixes opencast#457.
JulianKniephoff added a commit to JulianKniephoff/annotation-tool that referenced this issue Dec 20, 2023
Not all of the libraries we were using could be found
(in the correct version) in NPM, so had to get creative
with some of them.

I tried to stick to our current versions as closely as possible,
except for some that were easy to update. Thus, most versions are
pinned instead of using the usual `^x.y.z` constraint. Only ones
where we are using a current version anyway, and where minor updates
should be fine use the more traditional constraint.

Here are the detailed notes about where dependencies (might have)
changed:

* `vis-timeline` should be in the correct version, but the NPM build
  is a few moments younger, and differs slightly. I hope it's just
  variable naming or something like that, but comparing minified JS
  is hard, so I'm not 100% sure.
* `jquery.colorPicker` (or rather `really-simple-colorpicker` as the
  NPM package is called) is newer, because the original version isn't
  in NPM. Our use of it is relatively isolated, though, and it still
  seems to work superficially, so I'm relatively confident that this
  is fine.
* `jquery.appear` was never actually in use, so I removed it.
* `jquery` itself is updated to `1.8.2`. We were on `1.8.0` which is
  not in NPM. `1.8.2` is, and that should be fine, but jQuery is one
  of these candidates that you can never really be sure about since it
  doesn't follow SemVer perfectly and is used so pervasively, that
  even checking all our usages against the changelog is basically
  impossible.
* `i18next-xhr-backend` was replaced with (the newest version of)
  `i18next-http-backend`. The former is deprecated and not in NPM
  anymore, but the update here is literally a drop in replacement,
  apparently.
* Our Bootstrap version (`2.3.2`) is so dead it's not even funny.
  No `2.x` release is in NPM. Fortunately in this case one can just
  install it directly from their GitHub using the appropriate tag,
  but this is a bit shady and I want to get rid of it sooner rather
  than later. Unfortunately upgrading Bootstrap is a rather invasive
  step.
* The Bootstrap slider thing we were using doesn't even have a GitHub.
  I replaced it with one that does, and which is based on our original
  one. I used the oldest release they have on GitHub, and seems to be
  more or less the same, still, but there have been significant code
  changes between the two. As with the color picker, this is a rather
  isolated thing, though, so we should be fine?
* The RequireJS `text` plugin wasn't used anymore, so I got rid of it.
* RequireJS `domReady` only has newer versions in NPM, but they seem
  to work fine, even though there was a major jump here.
* `moment` got a minor update because the version we were using was
  actually incompatible with our `vis-timeline` version, and our own
  few uses should still work exactly the same. Note that this is
  merely a convenience to make `npm install` work. We are using
  all of these libraries pre-bundled, so `vis-timeline` isn't actually
  using the version of `moment` we are including, but rather comes
  with its own.

Fixes opencast#138.
Fixes opencast#457.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant