Properly set theme default configuration #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of properly setting the default value for `admin.themes.enabled` in the admin interface, we temporarily set it in the Opencast configuration. That's not a great workaround and it has a few problems, but I let us backport the admin interface to `r/15.x` to fix the major problems there. Not that 15 is our legacy release and we already have a two 16.x versions out, it's time to properly set the default value.
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/848/2024-07-21_13-52-55/ . |
|
Are you going to do a PR fixing it in the mainline repo as well? From 16.x: Immediate issues:
:D |
gregorydlogan
added a commit
to gregorydlogan/opencast-admin-interface
that referenced
this pull request
Jul 23, 2024
…e into main Pull request opencast#848 Properly set theme default configuration
lkiesow
added a commit
to lkiesow/opencast
that referenced
this pull request
Jul 24, 2024
This accompanies opencast/opencast-admin-interface#848 Since we now set the default we want in the admin interface itself, we no longer need to overwrite this in the configuration.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of properly setting the default value for
admin.themes.enabledin the admin interface, we temporarily set it in the Opencast configuration. That's not a great workaround and it has a few problems, but I let us backport the admin interface tor/15.xto fix the major problems there.Not that 15 is our legacy release and we already have a two 16.x versions out, it's time to properly set the default value.