Replace CRA with Vite #1265
Merged
Replace CRA with Vite #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One way to resolve opencast#1253. Demonstration of replacing create-react-app with vite. Got this working in a couple hours. Vite was chosen because: - Straightforward migration - Relatively similar set of opinions as CRA - Optimized for single page applications like ours - Popular
Arnei
added
type:dependencies
|
This pull request is deployed at test.editor.opencast.org/1265/2024-01-29_14-40-37/ . |
|
This pull request is deployed at test.editor.opencast.org/1265/2024-01-30_15-06-18/ . |
Fix port, as vite runs under a different port per default. Also fix the environment variable path.
Arnei
force-pushed
the
migrate-to-vite
branch
from
2ab3c78 to
8eaa396
Compare
|
This pull request is deployed at test.editor.opencast.org/1265/2024-01-31_11-20-00/ . |
geichelberger
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One way to resolve #1253.
Demonstration of replacing create-react-app with vite. Got this working in a couple hours.
Vite was chosen because:
Fairly happy with this so far, if only for the fact that it let's us get rid of some old tech debt. And vite is indeed miles faster in development than CRA. Also gets the size of our build folder down from 9,8M to 1,7M.
ToDos: