-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make editor logo changeable #1336
Conversation
Discussed this at the technical meeting |
From the Dev meeting: There were general thoughts on rebranding, but nobody was strongly against this specific pull request. |
You added the logo to somewhere else, but it's also still at the old location, isn't it? Can we move that instead? |
Yes, I will do that. I also saw that I cannot add a label to the PR and it looks like a proper label is required. Is there a way in which I can add a label? |
… deleted editor-logo.svg
As member of the institution (University of Vienna) that requested this feature I just wanted to add some notes about the motivation - I couldn't speak up in technical meeting because I was in a crowded tram with headphones only. Personally I'm no big fan of relabeling, because I think it is misleading for users, causes unnecessary overhead and you're running in inconsistencies. But it's not my call. On the other hand I'm running three instances with multiple tenants and I use different color schemes/logos to be able to identify the actual instance/tenant at a glance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the checkstyle issues.
This changes the logo CSS. The logo now looks slightly different from before, making it less similar to Studio than before? The logo is shifted slightly to the right, and has less contrast in dark mode.
Does fix the logo size in dark mode, as Martin mentioned. Never noticed that o.O
I also noticed, that the logo is styled slightly different, but I think, these changes are intentionally. |
This pull request is deployed at test.editor.opencast.org/1336/2024-06-12_10-59-44/ . |
Thanks for the comments, since this was the first project I was working on I completely forgot to check the Logo's appearances in different Themes. The contrast in darkmode is now similar to the contrast in Studio and the slightly shift is also gone. |
This pull request is deployed at test.editor.opencast.org/1336/2024-06-12_11-06-19/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vite still reports three checkstyle issues.
96:1 warning Expected indentation of 4 spaces but found 6 indent
106:1 warning Expected indentation of 4 spaces but found 6 indent
107:4 warning Missing semicolon semi
The CSS looks good to me now. Since Martin said this works, I believe this can be merged once the checkstyle stuff is out of the way.
This pull request is deployed at test.editor.opencast.org/1336/2024-07-01_06-58-35/ . |
This pull request is deployed at test.editor.opencast.org/1336/2024-07-01_07-11-17/ . |
Makes the editor logo changeable similar to the studio logo.