Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit "preview" in video flavors drop down of subtitle editor #978

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Omit "preview" in video flavors drop down of subtitle editor #978

merged 2 commits into from
Mar 1, 2023

Conversation

dennis531
Copy link
Collaborator

The implementation simply omits the subtypes if subtypes of all tracks are equal

Resolves #927

Omit "preview" in video flavors drop down of subtitle editor
715a445 
The implementation simply omits the subtypes if subtypes of all tracks are equal

Resolves opencast#927
@Arnei Arnei added the type:visual-clarity A part of the UI is not visually readable label Feb 20, 2023
Arnei
Arnei requested changes Feb 20, 2023
View reviewed changes
Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this works as advertised, it also breaks the selection part of the dropdown. I am unable to switch to another video. The dropdown updates correctly (in the sense that it displays what I selected), but the video in the player does not change.

Fix video flavor selection in subtitles editor
d31638d 
Currently, the video in the player doesn't change when an item is selected in the dropdown. These changes fix this issue.

Refs opencast#927
@Arnei Arnei merged commit 7decd00 into opencast:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arnei Arnei Arnei approved these changes

Assignees
No one assigned
Labels
type:visual-clarity A part of the UI is not visually readable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subtitle editor, omit "preview" in video flavors drop down
2 participants
@dennis531 @Arnei