Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK-5055 - ERROR CLI Opencga-enterprise #2354

Merged
merged 11 commits into from
Nov 6, 2023
Merged

TASK-5055 - ERROR CLI Opencga-enterprise #2354

merged 11 commits into from
Nov 6, 2023

Conversation

juanfeSanahuja
Copy link
Member

TASK-5055 - ERROR CLI Opencga-enterprise

@juanfeSanahuja
Copy link
Member Author

Task linked: TASK-5055 ERROR CLI Opencga-enterprise

@juanfeSanahuja juanfeSanahuja requested review from jtarraga, pfurio and imedina and removed request for jtarraga October 25, 2023 15:51
imedina
imedina previously approved these changes Oct 26, 2023
@@ -346,6 +346,7 @@
<arg value="${project.basedir}/../opencga-core/target/classes/log4j2.internal.xml"/>
<arg value="${project.basedir}/../opencga-storage/opencga-storage-core/target/classes/storage-configuration.yml"/>
<arg value="${project.basedir}/../opencga-client/target/classes/client-configuration.yml"/>
<arg value="${project.basedir}/src/main/resources/usage.yml"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't exist. It's called "cli-usage.yml"

/**
* FILENAME is the file location of the configuration yml file
*/
public static final String CLI_USAGE_FILENAME = "cli-usage.yml";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discrepancy between file name. In POM.xml it's expected to be "usage.yml"

opencga-app/src/main/resources/cli-usage.yml Show resolved Hide resolved
j-coll
j-coll previously approved these changes Nov 3, 2023
@juanfeSanahuja juanfeSanahuja merged commit f025493 into develop Nov 6, 2023
8 of 9 checks passed
@juanfeSanahuja juanfeSanahuja deleted the TASK-5055 branch November 6, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants