Skip to content

Pygeoapi provider [Completed ] #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Mar 10, 2023

Conversation

chinedu117
Copy link
Contributor

@chinedu117 chinedu117 commented Feb 21, 2023

@isedwards @david-i-berry

Please review the changes notably :

  • the Geography column definition SRID 4326
  • the storage of Point object as binary (WKB)
  • the derivation of lat lon from Point object instead of writing join queries (note: location is part of observation in CDM and OGC OMS)
  • etc
    Please let me know your thoughts as i write tests for these.

@cla-bot cla-bot bot added the cla-signed label Feb 21, 2023
@david-i-berry
Copy link
Contributor

In PostGIS we can have mixed geography types in the same column so at this stage I would leave it as a generic geography type. As way of example see a quick test below:

image.png

@david-i-berry
Copy link
Contributor

The geographies in the column need to have the same SRID but we may want to allows SRIDs other than 4326. We can take this question to the TT-CDM but my preference is to be flexible as long as the CRS / SRID is reported in the data model.

@chinedu117
Copy link
Contributor Author

chinedu117 commented Feb 23, 2023

The geographies in the column need to have the same SRID but we may want to allows SRIDs other than 4326. We can take this question to the TT-CDM but my preference is to be flexible as long as the CRS / SRID is reported in the data model.

Thanks for the insight. Could we instead enforce SRID 4326 ? We can always convert from one SRID to another using postgis or geoalchemy's ST_Transform method. So we would only expect the srid to be in one format for all our calculations.

@david-i-berry
Copy link
Contributor

The geographies in the column need to have the same SRID but we may want to allows SRIDs other than 4326. We can take this question to the TT-CDM but my preference is to be flexible as long as the CRS / SRID is reported in the data model.

Thanks for the insight. Could we instead enforce SRID 4326 ? We can always convert from one SRID to another using postgis or geoalchemy's ST_Transform method. So we would only expect the srid to be in one format for all our calculations.

That's a good point, in terms of implementation we can insist on 4326 but then provide the mechanism for transformation to other SRIDs.

@chinedu117 chinedu117 changed the title Pygeoapi provider [WIP] Pygeoapi provider [Completed ] Mar 2, 2023
@chinedu117
Copy link
Contributor Author

image

@chinedu117
Copy link
Contributor Author

image

@isedwards isedwards merged commit e088784 into opencdms-dev:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants