Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the problems with session id #708

Merged
merged 3 commits into from
Mar 16, 2024
Merged

Fix the problems with session id #708

merged 3 commits into from
Mar 16, 2024

Conversation

faltawy
Copy link
Collaborator

@faltawy faltawy commented Mar 16, 2024

  • Reorder Context Providers & Fix the changing session id
  • Release 2.8.9
  • Update dependencies for copilot-widget

@faltawy faltawy merged commit 467c9be into main Mar 16, 2024
3 checks passed
@faltawy faltawy deleted the fix-the-session-id branch March 16, 2024 22:06
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 16, 2024
View reviewed changes
copilot-widget/lib/contexts/axiosInstance.tsx
const config = useConfigData();
const { sessionId } = useSessionId(config?.token || "defaultToken");
const { token, apiUrl } = useConfigData();
const sessionId = useMemo(() => token + "|" + randomString(), [token]);

Check failure

Code scanning / CodeQL

Insecure randomness High

This uses a cryptographically insecure random number generated at
Math.random()
Loading
in a security context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@faltawy