Add UK Electoral Divisions #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
commented
Aug 19, 2018
| # in England, Wales, Scotland and Northern Ireland | ||
| pcon = { | ||
| # data from: http://geoportal.statistics.gov.uk/datasets/westminster-parliamentary-constituencies-december-2017-full-extent-boundaries-in-the-uk-wgs84 | ||
| 'url': 'https://opendata.arcgis.com/datasets/5c582cef61d04618928639dd17e4f896_1.csv', |
There was a problem hiding this comment.
Would it be better to commit the source CSV files here and document where they came from instead of linking them directly so that this process is more "reproducible". I can see reason for going either way on this. Happy to take guidance.
|
Hi. Any update on this? It would be really useful to get a review from a maintainer on this. </polite bump> |
|
Sure, i'll check this over this weekend. |
|
@jpmckinney this all built fine, and the output looks solid to me. |
|
Thanks! |
|
🎉 Excellent – I'd just started reviewing (I work with Chris so knew some of what he'd done already). All looks great, and thanks for merging! |
|
thanks, all 👍 |
This was referenced Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows on from the conversation started in #152
Done in this PR:
I've started off by adding scripts to create ids from ONS data for:
I look forward to review/feedback on this.
Possible Future Work:
Inevitably at some point there will be changes to these divisions which we need to account for. The next substantial legislative change to impact these divisions is likely to be this review of UK Parliamentary Consitituencies:
I'm happy to keep on top of this moving forwards.
At the moment everything has a current GSS code. These boundaries are relatively stable and change quite infrequently, but many of the divisions in this dataset have had boundary changes at some point and hence it is useful to be able to map a division to >1 GSS codes based on a date range.
I have not attempted to deal with that here but I may look at using the Code History Database to do this as future work.
As discussed in #152 there is a large body of division identifiers (mainly relevant to local elections) which have some additional complexity. Lets review the best way to manage them in light of future interest/use-cases.