Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canada electoral districts 2023 #364

Merged

Conversation

NikolasYo
Copy link
Contributor

Adding the constituency changes according to the Canadian electoral commission (2023)

Also attaching a README file with sources for those changes

Copy link
Contributor

@evannjw evannjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add 2024-04-23 as validThrough date to the ids in the identifiers/country-ca/ca_federal_electoral_districts-2013.csv file?

Also consider adding the 2013 ids which share the same district name as aliases here. Will defer to @jpmckinney on this.

@jpmckinney
Copy link
Member

@NikolasYo Can you review #327 first? Ideally we would merge that, and then make additional changes.

@NikolasYo
Copy link
Contributor Author

We reviewed the previous request #327 with @zikowang. From our side, you can merge, and we will work on the new EDs afterwards. We will keep the same ID for the EDs that stay the same and add validFrom and validThrough dates.

@jpmckinney
Copy link
Member

@NikolasYo Do you mean you would like this PR to be merged, but that you'll later make aliases for these to other OCDIDs (following the pattern in #327)?

@zikowang zikowang mentioned this pull request Feb 8, 2024
@zikowang
Copy link
Contributor

zikowang commented Feb 8, 2024

@jpmckinney we would wait for #327 to be merged and adjust this PR after accordingly.

@zikowang
Copy link
Contributor

zikowang commented Feb 13, 2024

The 2013 file is updated (added validThrough).
The aliases.csv is updated with 2023 aliases matching the 2013 aliases.
The README updated with sources for the 2023 changes.

@evannjw @jpmckinney would be great if you could have a look into this approach and if I am missing something.

ocd-division/country:ca/ed:59043-2023,ocd-division/country:ca/province:bc/ed:west_vancouver-sunshine_coast-sea_to_sky_country
ocd-division/country:ca/ed:60001-2023,ocd-division/country:ca/territory:yt/ed:yukon-1953
ocd-division/country:ca/ed:61001-2023,ocd-division/country:ca/territory:nt/ed:northwest_territories-2015
ocd-division/country:ca/ed:62001-2023,ocd-division/country:ca/territory:nu/ed:nunavut
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but why do only 233 out of 343 "-2023" OCD IDs have aliases?

Copy link
Contributor

@zikowang zikowang Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OCDs that are new or have other name in the 2023 file compared to the 2013 file don't have aliases.

Should there be an alias for each entry in the 2023 file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in #323 we basically agreed to have:

  1. ID and year based OCD IDs, for easy reconciliation with new boundary files.
  2. Name-based OCD IDs that reconcile with data from the Library of Parliament.

The scripts/country-ca/ca_federal_electoral_districts.py script was created to assist here. You might need to run it (and possibly edit it to accommodate the new IDs).

@NikolasYo
Copy link
Contributor Author

The source mentioned https://lop.parl.ca/sites/ParlInfo/default/en_CA/ElectionsRidings/Ridings is not up to date as it contains 338 active constituencies instead of 343

After examining the changes in the electoral districts we came across multiple examples of electoral district names staying the same, despite changes in their borders. You can see it visually here https://redecoupage-redistribution-2022.ca/ebv2/index.html?locale=en-ca .

For example ED Selkirk—Interlake—Eastman kept the same name after the 2023 changes, but it’s border was modified, losing an area in the south against ED Winnipeg West and gaining an area in the north from ED Churchill—Keewatinook Aski. Such changes (Same ED name but different borders) are noticeable in many constituencies.

Our proposal would be to treat all the 2023 Electoral Districts as new, due to the numerous changes in the borders. Would you prefer to treat constituencies that have changed their borders as continuous solely based on the fact of them keeping the same name (Alias)?

@jpmckinney
Copy link
Member

jpmckinney commented Feb 22, 2024

Our proposal would be to treat all the 2023 Electoral Districts as new, due to the numerous changes in the borders.

A division (political geography) is not the same as a boundary per OCDEP 2. So, borders can change without yielding a new division. This is important, because borders can change in very small ways that don't matter at all in terms of political geography (e.g. a resident would be quite surprised to learn that they live in a "new" district if all that changed was that a point in a polygon moved from one side of the street to the other).

Would you prefer to treat constituencies that have changed their borders as continuous solely based on the fact of them keeping the same name (Alias)?

Name doesn't matter at all in determining continuity over time.

  • In Canada, Members of Parliament frequently rename districts for any reason, without any boundary change.
  • On the flip side, there are cases where the Library of Parliament deems two divisions to be distinct, despite having the same name, due to perhaps some major change in boundary.

To answer the question behind your question: Whether two divisions are different or the same is a political decision. In Canada, we treat the Library of Parliament as the authoritative source on what has been politically decided.

LOP has not yet caught up on recent changes. So, for now, we can just create the "-2023" OCDIDs and NOT add any aliases, until our source for aliases is available.

@zikowang
Copy link
Contributor

zikowang commented Feb 23, 2024

@jpmckinney thanks for the clarification.
I pushed a new commit removing the aliases for CA "-2023" ocd-ids.

@zikowang
Copy link
Contributor

@jloutsenhizer @azuser
could you please have a short look?

@jloutsenhizer jloutsenhizer self-requested a review February 26, 2024 14:29
@jloutsenhizer jloutsenhizer merged commit 0a86b19 into opencivicdata:master Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants