Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pv-site dynamic normalizing #363

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Sep 16, 2024

Pull Request

Description

Upgrade from normalizing of pv with a dynaimc capacity number
before it was hard coded for the RUVNL site

This will help openclimatefix/india-forecast-app#78

When retraining RUVNL, we might need to factor this in, or add a dynamic capacity data column

How Has This Been Tested?

  • Tested this by running the forecast ad india app locally

  • CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield changed the title change to use x.nominal_capacity_wp for normalization with for pv s… pv-site dynamic normalizing Sep 16, 2024
@peterdudfield peterdudfield merged commit cde0890 into main Sep 16, 2024
3 checks passed
@peterdudfield peterdudfield deleted the issue/pv-site-normalization branch September 16, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants