Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pure CSS Images Task 1 - Wine Glass #10

Merged
merged 2 commits into from
Jan 14, 2018
Merged

Pure CSS Images Task 1 - Wine Glass #10

merged 2 commits into from
Jan 14, 2018

Conversation

nikki1016
Copy link
Contributor

issue no. #5

@gauthamzz
Copy link
Member

Why is there a face on wine glass ?

@nikki1016
Copy link
Contributor Author

nikki1016 commented Jan 14, 2018 •
edited
Loading

just to make it more interesting..anyway it is DIY wine glass ..
should I modify it ?

@mubaris
Copy link
Contributor

mubaris commented Jan 14, 2018

I think it's okay

@gauthamzz gauthamzz merged commit 044d338 into opencode18:master Jan 14, 2018
@gauthamzz
Copy link
Member

when you scrolled it up,it felt like the face was coming off the wine glass. Seems like they are seprate parts or something.

anyway okay

@nikki1016
Copy link
Contributor Author

I will remove that face part....It is my first pure CSS image

@gauthamzz
Copy link
Member

nah its okay 😄

@ananya ananya mentioned this pull request Jan 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mubaris mubaris mubaris approved these changes

@gauthamzz gauthamzz Awaiting requested review from gauthamzz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikki1016 @gauthamzz @mubaris