CollectivePage: Don't crash with minor GraphQL errors #6122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/opencollective/opencollective-frontend/HJUGPqUAQZtWTbai7epMwu4H7F38 |
Betree
force-pushed
the
enhancement/collective-page-no-crash
branch
from
20ad609 to
94ce5bb
Compare
Betree
commented
Mar 26, 2021
| skipDataFromTree = true; | ||
| } catch (e) { | ||
| console.error(`Collective page: unable to preload data for ${slug}`, e); | ||
| ssrGraphqlError = e; |
There was a problem hiding this comment.
Had to come up with this workaround because of apollographql/apollo-client#4644
Betree
changed the title
Betree
force-pushed
the
enhancement/collective-page-no-crash
branch
from
94ce5bb to
3ba29f5
Compare
|
It's difficult to achieve with our current configuration, we may revisit later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the situation for Fixer outage by "hiding" the amounts that we're not able to display and showing an error toast rather than crashing the entire page:
TODO: