Merged
Conversation
abdoo8080
approved these changes
Jan 29, 2026
Collaborator
abdoo8080
left a comment
abdoo8080
left a comment
There was a problem hiding this comment.
LGTM! Left minor comments to eventually resolve!
Co-authored-by: Abdalrhman Mohamed <abdoo8080@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the SMT-LIB formalization of floating point.
We break the SMT-LIB definitions into typeclasses and structures that capture orthogonal portions of the spec.
We define the
roundfunction as per SMT-LIB, as well as the semantics of the basic floating point operations. Finally, we instantiate this on the extended reals.A follow-up PR will instantiate these on the rational numbers for exhaustive enumeration based testing.