remove logic of api returning a "rendered" response as it can't happen #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardo-devis-agullo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking at the logic, and for both calls (render and getData), we use the getHeaders function that always add the header
Accept: 'application/vnd.oc.unrendered+json'to the request.When that happens, the response is always going to be unrendered, with one single exception, which is when oc-client-node calls the endpoint and the template is not supported (see here). This can only happen with node, where the node client will send a specific oc-client user agent string, so I don't see how it can ever happen in a browser context.
I got to think that some time ago this code was somehow moved from server to client and found it's way there, but I think is 100% safe to remove.